This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Use Github Actions #342
Merged
Use Github Actions #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
dani-santos-code
force-pushed
the
github-actions
branch
from
13b685c to
e33f0a9
Compare
dani-santos-code
force-pushed
the
github-actions
branch
from
e33f0a9 to
5e949a9
Compare
dani-santos-code
force-pushed
the
github-actions
branch
from
4dddbce to
5bd7a41
Compare
genevieveluyt
commented
May 25, 2021
| @@ -0,0 +1,25 @@ | |||
| name: CI | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
Will this still re-run CI if you push commits to a PR? For example, if tests fail and you push a new commit to fix the test, I think we want CI to run again?
There was a problem hiding this comment.
Every time we push a commit to this PR, ci will re-run. You can see the little check next to every commit:
Is that what you mean? 🤔
|
Looks good! I can't approve because I opened the PR but 👍 |
dani-santos-code
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Github Actions for CI
Fixes #336
Type of change
How Has This Been Tested?
Checklist: