This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Deprecate mountds command #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-santos-code
previously approved these changes
Apr 15, 2021
There was a problem hiding this comment.
I guess you need to remove mountds from the config fixture, since config is used with all and we're removing it from there
ghost
added
the
dani-santos-code
approved these changes
Apr 15, 2021
Closed
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
mountdsfrom theallcommand (should be a no-op since themountscommand tests for the same things and more).Also adds a deprecation notice at the top of the results (if using pretty print output)