Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Use Github Actions #342

Merged
merged 5 commits into from
May 25, 2021
Merged

Use Github Actions #342

merged 5 commits into from
May 25, 2021

Conversation

genevieveluyt
Copy link
Contributor

Description

Use Github Actions for CI

Fixes #336

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
How Has This Been Tested?
  • Test A
  • Test B
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

@ghost ghost added config readme labels May 25, 2021
genevieveluyt
genevieveluyt commented May 25, 2021
View reviewed changes
.github/workflows/ci.yml
@@ -0,0 +1,25 @@
name: CI
on:
push:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this still re-run CI if you push commits to a PR? For example, if tests fail and you push a new commit to fix the test, I think we want CI to run again?

Copy link
Contributor

@dani-santos-code dani-santos-code May 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time we push a commit to this PR, ci will re-run. You can see the little check next to every commit:

Screen Shot 2021-05-25 at 4 46 34 PM

Is that what you mean? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice yea!

@genevieveluyt genevieveluyt marked this pull request as ready for review May 25, 2021 20:48
@genevieveluyt
Copy link
Contributor Author

Looks good! I can't approve because I opened the PR but 👍

@dani-santos-code dani-santos-code merged commit 5c9d942 into master May 25, 2021
@dani-santos-code dani-santos-code deleted the github-actions branch May 25, 2021 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dani-santos-code dani-santos-code dani-santos-code approved these changes

Assignees
No one assigned
Labels
config readme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github actions for testing (instead of Travis)
2 participants
@genevieveluyt @dani-santos-code