Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Commit

Permalink
add CLA link to Contributing (#222)
Browse files Browse the repository at this point in the history
* add CLA link to Contributing

* adds CLA link to PR template

* adds note about re-running CLA check

* updates welcome to include links
  • Loading branch information
catherinejones authored Aug 21, 2019
1 parent 9c1546f commit ef7adb1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ Fixes # (issue)
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] The test coverage did not decrease
- [ ] I have signed the appropriate [Contributor License Agreement](https://cla.shopify.com/)
2 changes: 1 addition & 1 deletion .github/welcome.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ newIssueWelcomeComment: >
Thanks for opening your first issue here! Be sure to follow the issue template!
newPRWelcomeComment: >
Thanks for opening this pull request! Please check out our contributing guidelines and sign the CLA.
Thanks for opening this pull request! Please check out our [contributing guidelines](https://github.com/Shopify/kubeaudit#contribute) and [sign the CLA](https://cla.shopify.com/).
firstPRMergeComment: >
Congrats on merging your first pull request, keep em coming!
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,9 @@ If you'd like to fix a bug, contribute a feature or just correct a typo, please
1. Run the tests to see everything is working as expected: `make test`
1. Commit your changes: `git commit -am 'Adds awesome feature'`
1. Push to the branch: `git push fork`
1. Sign the [Contributor License Agreement](https://cla.shopify.com/)
1. Submit a PR (All PR must be labeled with :bug: (Bug fix), :sparkles: (New feature), :book: (Documentation update), or :warning: (Breaking changes) )
1. ???
1. Profit

Note that if you didn't sign the CLA before opening your PR, you can re-run the check by adding a comment to the PR that says "I've signed the CLA!"!

0 comments on commit ef7adb1

Please sign in to comment.