Skip to content

Revise PR to Retain React Templates and Add Preact Ones #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: cx_migrate_pos_templates_to_preact
Choose a base branch
from
Open

Revise PR to Retain React Templates and Add Preact Ones #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions admin-action/package.json.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
{%- elsif flavor contains "react" %}
"dependencies": {
"react": "^18.0.0",
"@shopify/ui-extensions": "2025.4.x",
"@shopify/ui-extensions-react": "2025.4.x",
"@shopify/ui-extensions": "2025.7.x",
"@shopify/ui-extensions-react": "2025.7.x",
"react-reconciler": "0.29.0"
},
"devDependencies": {
"@types/react": "^18.0.0"
}
{%- else %}
"dependencies": {
"@shopify/ui-extensions": "2025.4.x"
"@shopify/ui-extensions": "2025.7.x"
}
{%- endif %}
}
2 changes: 1 addition & 1 deletion admin-action/shopify.extension.toml.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{%- if flavor contains "preact" -%}
api_version = "2025-10"
{% else %}
api_version = "2025-04"
api_version = "2025-07"
{% endif -%}

[[extensions]]
Expand Down
6 changes: 3 additions & 3 deletions admin-block/package.json.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
{%- elsif flavor contains "react" %}
"dependencies": {
"react": "^18.0.0",
"@shopify/ui-extensions": "2025.4.x",
"@shopify/ui-extensions-react": "2025.4.x",
"@shopify/ui-extensions": "2025.7.x",
"@shopify/ui-extensions-react": "2025.7.x",
"react-reconciler": "0.29.0"
},
"devDependencies": {
"@types/react": "^18.0.0"
}
{%- else %}
"dependencies": {
"@shopify/ui-extensions": "2025.4.x"
"@shopify/ui-extensions": "2025.7.x"
}
{%- endif %}
}
2 changes: 1 addition & 1 deletion admin-block/shopify.extension.toml.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{%- if flavor contains "preact" -%}
api_version = "2025-10"
{% else %}
api_version = "2025-04"
api_version = "2025-07"
{% endif -%}

[[extensions]]
Expand Down
6 changes: 3 additions & 3 deletions admin-print-action/package.json.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
{%- elsif flavor contains "react" %}
"dependencies": {
"react": "^18.0.0",
"@shopify/ui-extensions": "2025.4.x",
"@shopify/ui-extensions-react": "2025.4.x",
"@shopify/ui-extensions": "2025.7.x",
"@shopify/ui-extensions-react": "2025.7.x",
"react-reconciler": "0.29.0"
},
"devDependencies": {
"@types/react": "^18.0.0"
}
{%- else %}
"dependencies": {
"@shopify/ui-extensions": "2025.4.x"
"@shopify/ui-extensions": "2025.7.x"
}
{%- endif %}
}
2 changes: 1 addition & 1 deletion admin-print-action/shopify.extension.toml.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{%- if flavor contains "preact" -%}
api_version = "2025-10"
{% else %}
api_version = "2025-04"
api_version = "2025-07"
{% endif -%}

[[extensions]]
Expand Down
6 changes: 3 additions & 3 deletions admin-purchase-options-action/package.json.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
{%- elsif flavor contains "react" %}
"dependencies": {
"react": "^18.0.0",
"@shopify/ui-extensions": "2025.4.x",
"@shopify/ui-extensions-react": "2025.4.x",
"@shopify/ui-extensions": "2025.7.x",
"@shopify/ui-extensions-react": "2025.7.x",
"react-reconciler": "0.29.0"
},
"devDependencies": {
"@types/react": "^18.0.0"
}
{%- else %}
"dependencies": {
"@shopify/ui-extensions": "2025.4.x"
"@shopify/ui-extensions": "2025.7.x"
}
{%- endif %}
}
2 changes: 1 addition & 1 deletion admin-purchase-options-action/shopify.extension.toml.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{%- if flavor contains "preact" -%}
api_version = "2025-10"
{% else %}
api_version = "2025-04"
api_version = "2025-07"
{% endif %}

[[extensions]]
Expand Down
25 changes: 12 additions & 13 deletions customer-segment-template-extension/package.json.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
{%- if flavor contains "react" -%}
{
"name": "{{ handle }}",
"private": true,
"version": "1.0.0",
"license": "UNLICENSED",
{%- if flavor contains "preact" %}
"dependencies": {
"preact": "^10.10.x",
"@shopify/ui-extensions": "~2025.10.0-rc"
}
{%- elsif flavor contains "react" %}
"dependencies": {
"react": "^18.0.0",
"@shopify/ui-extensions": "2024.7.x",
"@shopify/ui-extensions-react": "2024.7.x",
"@shopify/ui-extensions": "2025.7.x",
"@shopify/ui-extensions-react": "2025.7.x",
"react-reconciler": "0.29.0"
},
"devDependencies": {
"@types/react": "^18.0.0"
}
}
{%- else -%}
{
"name": "{{ handle }}",
"private": true,
"version": "1.0.0",
"license": "UNLICENSED",
{%- else %}
"dependencies": {
"@shopify/ui-extensions": "2024.7.x"
"@shopify/ui-extensions": "2025.7.x"
}
}
{%- endif -%}
{%- endif %}
}
8 changes: 6 additions & 2 deletions customer-segment-template-extension/shopify.extension.toml.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
api_version = "2024-07"
{%- if flavor contains "preact" -%}
api_version = "2025-10"
{% else %}
api_version = "2025-07"
{% endif -%}

[[extensions]]
# Change the merchant-facing name of the extension in locales/en.default.json
Expand All @@ -15,4 +19,4 @@ target = "admin.customers.segmentation-templates.render"

# Valid extension points:

# - admin.customers.segmentation-templates.render
# - admin.customers.segmentation-templates.render
28 changes: 26 additions & 2 deletions customer-segment-template-extension/src/CustomerSegmentTemplate.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,28 @@
{%- if flavor contains "react" -%}
{%- if flavor contains "preact" -%}
import {render} from 'preact';

const TARGET = 'admin.customers.segmentation-templates.render';

export default function() {
render(<App />, document.body);
}

function App() {
const query = 'number_of_orders = 1 AND products_purchased(id: (product_id)) = true';
const queryToInsert = 'number_of_orders = 1 AND products_purchased(id: (';

return (
<s-customer-segment-template
title={shopify.i18n.translate('title')}
description={shopify.i18n.translate('description')}
createdOn={new Date('2023-08-15').toISOString()}
query={query}
queryToInsert={queryToInsert}
/>
);
}

{%- elsif flavor contains "react" -%}
import {
reactExtension,
CustomerSegmentTemplate,
Expand Down Expand Up @@ -49,4 +73,4 @@ export default extension("admin.customers.segmentation-templates.render", (root,
)
);
});
{%- endif -%}
{%- endif -%}
26 changes: 12 additions & 14 deletions discount-details-function-settings-block/package.json.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,26 @@
{%- if flavor contains "react" -%}
{
"name": "{{ handle }}",
"private": true,
"version": "1.0.0",
"license": "UNLICENSED",
{%- if flavor contains "preact" %}
"dependencies": {
"preact": "^10.10.x",
"@shopify/ui-extensions": "~2025.10.0-rc"
}
{%- elsif flavor contains "react" %}
"dependencies": {
"react": "^18.0.0",
"@shopify/ui-extensions": "2024.10.x",
"@shopify/ui-extensions-react": "2024.10.x",
"@shopify/ui-extensions": "2025.7.x",
"@shopify/ui-extensions-react": "2025.7.x",
"react-reconciler": "0.29.0"
},
"devDependencies": {
"@types/react": "^18.0.0"
}
}
{%- else -%}
{
"name": "{{ handle }}",
"private": true,
"version": "1.0.0",
"license": "UNLICENSED",
{%- else %}
"dependencies": {
"@shopify/ui-extensions": "2024.10.x"
"@shopify/ui-extensions": "2025.7.x"
}
}
{%- endif -%}

{%- endif %}
}
8 changes: 6 additions & 2 deletions discount-details-function-settings-block/shopify.extension.toml.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
api_version = "2024-10"
{%- if flavor contains "preact" -%}
api_version = "2025-10"
{% else %}
api_version = "2025-07"
{% endif -%}

[[extensions]]
# Change the merchant-facing name of the extension in locales/en.default.json
Expand All @@ -12,4 +16,4 @@ type = "ui_extension"
[[extensions.targeting]]
module = "./src/DiscountFunctionSettings.{{ srcFileExtension }}"
# The target used here must match the target used in the module file (./src/DiscountFunctionSettings.{{ srcFileExtension }})
target = "admin.discount-details.function-settings.render"
target = "admin.discount-details.function-settings.render"
Loading