Akram Znini, [email protected] #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a reusable button component for start, stop, reset, and lap actions. - Defined explicit prop types to address TypeScript warnings.
- Added useEffect to update elapsed time every 100 milliseconds when running. - Exposed start, stop, reset, and getFormattedTime functions using useImperativeHandle. - Formatted time to display in "hh:mm:ss" format.
- Added functionality to start, stop, reset, and record laps in the stopwatch.
- Corrected a bug in the reset function within useImperativeHandle. - Previously, the 'isRunning' state was not set to false, causing incorrect behavior on reset. - Now, the reset function properly sets 'isRunning' to false, resolving the issue.
- Adjusted lap display to be scrollable - Fine-tuned styling for a visually appealing user interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the React Native Technical Challenge.