Skip to content

Conversation

Karine03
Copy link

PR Summary:

Localization form was displaying on header mobile even if localization settings were disabled.

Why are these changes introduced?

The eshop should not display localization form if vendor disabled it

Fixes #0.

What approach did you take?

I change the condition to match desktop header's conditions

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

none

Testing steps/scenarios

  • Step 1 : disable localization on the header settings
  • Check on mobile that the form is note displaying

Demo links

Checklist

Localization form was displaying on mobile even if localization settings were disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant