Repository navigation
fix: 窗口 chrome 按钮 stopPropagation 改 snake_case——Opal 下 camelCase 直接 raise - #4
Merged
Merged
Conversation
…aise Citrine::Event 只有 snake_case stop_propagation（event.rb）；beryl 窗口 最小化/最大化/关闭钮与对话框体四处调用 camelCase e.stopPropagation， 浏览器端点击即 NoMethodError，on_minimize/on_close 等回调永不到达 （ZUI 形态态机的 morph 入口即被此阻断）。CRuby 下单测不可见 （Event 视图层不参与 StringRenderer 派发），浏览器实证定位。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Citrine::Event只暴露 snake_casestop_propagation（citrine event.rb），beryl 四处调用 camelCasee.stopPropagation：window.rb最小化/最大化/关闭三颗 chrome 按钮dialog.rb对话框体（拦截背景点击穿透）浏览器（Opal）下点击即
NoMethodError，on_minimize\&./on_maximize\&./on_close\&.call在 raise 之后永不到达——窗口 chrome 全灭、ZUI 形态态机的 morph 最小化入口被完全阻断。CRuby 单测不可见（Event 视图层不参与 StringRenderer 派发），浏览器打点实证定位。修复
4 处 camelCase → snake_case 调用点（不改 citrine 加别名——DSL 全域 snake_case 红线）。beryl 82 项全绿；下游 emerald-zui 114 项全绿。
顺带发现（不在本 PR 范围）
beryl
setup_dblclick与 citrineEVENT_DEFS[:on_dblclick]双绑导致一次双击触发两次处理器——PR #2 合并后单独提删。