modernize typing across the board

mostly stops typing self and __all__ also patch the linter and remove some unused imports a little while i'm touching everything
ShineyDev · Jan 25, 2025 · c977697 · c977697
1 parent 6be56ab
commit c977697
Show file tree

Hide file tree

Showing 93 changed files with 787 additions and 887 deletions.
diff --git a/github/__init__.py b/github/__init__.py
@@ -39,7 +39,7 @@ class _VersionInfo(NamedTuple):
 version_info: _VersionInfo = _VersionInfo(1, 0, 0, 0, "alpha", 0)
 
 
-__all__: list[str] = [  # type: ignore[reportUnsupportedDunderAll]
+__all__ = [  # type: ignore[reportUnsupportedDunderAll]
     *_core__all__,
     *_interfaces__all__,
     *_api__all__,

diff --git a/github/api/__init__.py b/github/api/__init__.py
@@ -4,7 +4,7 @@
 from github.api.ratelimit import __all__ as _ratelimit__all__
 
 
-__all__: list[str] = [  # type: ignore[reportUnsupportedDunderAll]
+__all__ = [  # type: ignore[reportUnsupportedDunderAll]
     *_metadata__all__,
     *_ratelimit__all__,
 ]
diff --git a/github/api/metadata.py b/github/api/metadata.py
@@ -1,9 +1,6 @@
 from __future__ import annotations
 from typing import TYPE_CHECKING
 
-if TYPE_CHECKING:
-    from typing_extensions import Self
-
 from github.interfaces import Type
 
 
@@ -43,10 +40,10 @@ def _patch_data(
 
     @classmethod
     def _from_data(
-        cls: type[Self],
+        cls,
         data: MetadataData,
         /,
-    ) -> Self:
+    ):
         return cls(cls._patch_data(data))
 
     _graphql_fields = {
@@ -63,7 +60,7 @@ def _from_data(
 
     @property
     def enterprise_importer_ip_addresses(
-        self: Self,
+        self,
         /,
     ) -> list[str]:
         """
@@ -77,7 +74,7 @@ def enterprise_importer_ip_addresses(
 
     @property
     def git_ip_addresses(
-        self: Self,
+        self,
         /,
     ) -> list[str]:
         """
@@ -90,7 +87,7 @@ def git_ip_addresses(
 
     @property
     def github_services_sha(
-        self: Self,
+        self,
         /,
     ) -> str:
         """
@@ -103,7 +100,7 @@ def github_services_sha(
 
     @property
     def webhook_ip_addresses(
-        self: Self,
+        self,
         /,
     ) -> list[str]:
         """
@@ -116,7 +113,7 @@ def webhook_ip_addresses(
 
     @property
     def importer_ip_addresses(
-        self: Self,
+        self,
         /,
     ) -> list[str]:
         """
@@ -129,7 +126,7 @@ def importer_ip_addresses(
 
     @property
     def is_password_authentication_verifiable(
-        self: Self,
+        self,
         /,
     ) -> bool:
         """
@@ -147,7 +144,7 @@ def is_password_authentication_verifiable(
 
     @property
     def pages_ip_addresses(
-        self: Self,
+        self,
         /,
     ) -> list[str]:
         """
@@ -159,6 +156,6 @@ def pages_ip_addresses(
         return self._data["pagesIpAddresses"]
 
 
-__all__: list[str] = [
+__all__ = [
     "Metadata",
 ]
diff --git a/github/api/ratelimit.py b/github/api/ratelimit.py
@@ -2,8 +2,6 @@
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
-    from typing_extensions import Self
-
     from github.utility.types import DateTime
 
 import github
@@ -46,10 +44,10 @@ def _patch_data(
 
     @classmethod
     def _from_data(
-        cls: type[Self],
+        cls,
         data: RateLimitData,
         /,
-    ) -> Self:
+    ):
         return cls(cls._patch_data(data))
 
     _graphql_fields = {
@@ -61,7 +59,7 @@ def _from_data(
 
     @property
     def limit(
-        self: Self,
+        self,
         /,
     ) -> int:
         """
@@ -86,7 +84,7 @@ def limit(
 
     @property
     def remaining(
-        self: Self,
+        self,
         /,
     ) -> int:
         """
@@ -111,7 +109,7 @@ def remaining(
 
     @property
     def resets_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """
@@ -124,7 +122,7 @@ def resets_at(
 
     @property
     def used(
-        self: Self,
+        self,
         /,
     ) -> int:
         """
@@ -147,6 +145,6 @@ def used(
         return used
 
 
-__all__: list[str] = [
+__all__ = [
     "RateLimit",
 ]
diff --git a/github/automation/__init__.py b/github/automation/__init__.py
@@ -4,7 +4,7 @@
 from github.automation.mannequin import __all__ as _mannequin__all__
 
 
-__all__: list[str] = [  # type: ignore[reportUnsupportedDunderAll]
+__all__ = [  # type: ignore[reportUnsupportedDunderAll]
     *_bot__all__,
     *_mannequin__all__,
 ]
diff --git a/github/automation/bot.py b/github/automation/bot.py
@@ -3,7 +3,6 @@
 
 if TYPE_CHECKING:
     from typing import cast
-    from typing_extensions import Self
 
     from github.core.http import HTTPClient
     from github.utility.types import DateTime
@@ -59,12 +58,12 @@ def _patch_data(
 
     @classmethod
     def _from_data(
-        cls: type[Self],
+        cls,
         data: BotData,
         /,
         *,
         http: HTTPClient,
-    ) -> Self:
+    ):
         return cls(cls._patch_data(data), http)
 
     _graphql_fields = {
@@ -77,7 +76,7 @@ def _from_data(
 
     @property
     def created_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """
@@ -90,7 +89,7 @@ def created_at(
 
     @property
     def database_id(
-        self: Self,
+        self,
         /,
     ) -> int:
         """
@@ -103,7 +102,7 @@ def database_id(
 
     @property
     def updated_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """
@@ -115,7 +114,7 @@ def updated_at(
         return github.utility.iso_to_datetime(self._data["updatedAt"])
 
     async def fetch_created_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """
@@ -142,7 +141,7 @@ async def fetch_created_at(
         return github.utility.iso_to_datetime(created_at)
 
     async def fetch_database_id(
-        self: Self,
+        self,
         /,
     ) -> int:
         """
@@ -164,7 +163,7 @@ async def fetch_database_id(
         return await self._fetch_field("databaseId")  # type: ignore
 
     async def fetch_updated_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """

diff --git a/github/automation/mannequin.py b/github/automation/mannequin.py
@@ -3,7 +3,6 @@
 
 if TYPE_CHECKING:
     from typing import cast
-    from typing_extensions import Self
 
     from github.core.http import HTTPClient
     from github.utility.types import DateTime
@@ -62,12 +61,12 @@ def _patch_data(
 
     @classmethod
     def _from_data(
-        cls: type[Self],
+        cls,
         data: MannequinData,
         /,
         *,
         http: HTTPClient,
-    ) -> Self:
+    ):
         return cls(cls._patch_data(data), http)
 
     _graphql_fields = {
@@ -81,7 +80,7 @@ def _from_data(
 
     @property
     def created_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """
@@ -94,7 +93,7 @@ def created_at(
 
     @property
     def database_id(
-        self: Self,
+        self,
         /,
     ) -> int:
         """
@@ -107,7 +106,7 @@ def database_id(
 
     @property
     def updated_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """
@@ -119,7 +118,7 @@ def updated_at(
         return github.utility.iso_to_datetime(self._data["updatedAt"])
 
     async def fetch_created_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """
@@ -146,7 +145,7 @@ async def fetch_created_at(
         return github.utility.iso_to_datetime(created_at)
 
     async def fetch_database_id(
-        self: Self,
+        self,
         /,
     ) -> int:
         """
@@ -168,7 +167,7 @@ async def fetch_database_id(
         return await self._fetch_field("databaseId")  # type: ignore
 
     async def fetch_updated_at(
-        self: Self,
+        self,
         /,
     ) -> DateTime:
         """

diff --git a/github/connection/__init__.py b/github/connection/__init__.py
@@ -28,7 +28,7 @@
 from github.connection.vulnerabilityorder import __all__ as _vulnerabilityorder__all__
 
 
-__all__: list[str] = [  # type: ignore[reportUnsupportedDunderAll]
+__all__ = [  # type: ignore[reportUnsupportedDunderAll]
     *_advisoryorder__all__,
     *_connection__all__,
     *_discussionorder__all__,

diff --git a/github/connection/advisoryorder.py b/github/connection/advisoryorder.py
@@ -29,5 +29,5 @@ class AdvisoryOrder(enum.Enum):
 
 
 __all__ = [
-    "AdvisoryOrder"
+    "AdvisoryOrder",
 ]