Add bufrange to support reusing buffers#25
Open
martin-knopf wants to merge 1 commit intoSheetJS:masterfrom
Open
Add bufrange to support reusing buffers#25martin-knopf wants to merge 1 commit intoSheetJS:masterfrom
martin-knopf wants to merge 1 commit intoSheetJS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I have recently used this library in the context of content-defined chunking, where I read a file into a buffer and calculate hashes of a sliding window. This produces as many hashes as there are bytes in the buffer. To get the next window, I used
Buffer.subarray(), but this is pretty slow because it creates a new buffer. So, with this PR, I would like to proposeCRC32.bufrange(buffer, start, end, [, seed]), which allows reusing the same buffer.Unfortunately, I don’t understand your codebase well enough to know where this new function should go. For starters, I have only added it to
crc32.js, but I would be happy to complete this PR with your help.Best, Martin