chore: commentarySectionRef return null if too many sections #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1754,45 +1754,48 @@ Sefaria = extend(Sefaria, { | |||
| linkSummaryBookSortHebrew: function(category, a, b) { | |||
| return Sefaria.linkSummaryBookSort(category, a, b, true); | |||
| }, | |||
| commentarySectionRef: function(commentator, baseRef) { | |||
| commentarySectionRef: function(commentator, baseRef, tooManySections = 5) { | |||
There was a problem hiding this comment.
i hope this is not a nitpicking, but this number does not represent too many, but rather the upper bound of not too many. i'm not sure what is the best name here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commentaries like Malbim Ayelet HaShachar in the sidebar can cause hundreds of queries to get issued. This is because its structure is not similar to the base text, and so a link from a verse in the Torah can be connected to Malbim Ayelet HaShachar 1-603, yielding 603 calls.
Code Changes
The following changes were made to the files below
commentarySectionRefnow returns null if there are more thantooManySections/5 refs in the range. This number may be arbitrary but it seems reasonable to me.parseInt.