Skip to content

Commit

Permalink
Merge pull request #2281 from Sefaria/json-cleanup
Browse files Browse the repository at this point in the history
fix(helm): remove json file mount from rambi cronjob
  • Loading branch information
edamboritz authored Jan 27, 2025
2 parents e12c02f + ba8eead commit 9b6ef8a
Show file tree
Hide file tree
Showing 84 changed files with 6 additions and 16 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/helm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,15 @@ jobs:
- name: Checkout
uses: actions/checkout@v2
- name: Set up Helm
uses: azure/setup-helm@v1
with:
version: v3.5.0
uses: azure/[email protected]
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.7
- name: Set up chart-testing
uses: helm/[email protected]
with:
version: v3.5.1
- name: Lint chart
run: ct lint --charts helm-chart/sefaria-project
run: ct lint --charts helm-chart/sefaria

chart:
name: Release Chart
Expand Down Expand Up @@ -87,9 +83,9 @@ jobs:
wget -nv -nc -O yq https://github.com/mikefarah/yq/releases/download/v4.20.2/yq_linux_amd64
chmod +x yq
- name: Update chart version
run: ./yq -i e '.version = "${{ steps.chartVersion.outputs.chartVersion }}"' helm-chart/sefaria-project/Chart.yaml
run: ./yq -i e '.version = "${{ steps.chartVersion.outputs.chartVersion }}"' helm-chart/sefaria/Chart.yaml
- name: Update chart appVersion
run: ./yq -i e '.appVersion = "${{ steps.appVersion.outputs.appVersion }}"' helm-chart/sefaria-project/Chart.yaml
run: ./yq -i e '.appVersion = "${{ steps.appVersion.outputs.appVersion }}"' helm-chart/sefaria/Chart.yaml
- name: Publish Helm charts
uses: stefanprodan/helm-gh-pages@master
with:
Expand Down
2 changes: 1 addition & 1 deletion build/ci/integration-helm-deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ yq e -i '.secrets.localSettings.data.SEFARIA_DB = "sefaria-integration"' $1
yq e -i '.ingress.hosts[0].host = strenv(GIT_COMMIT)+".integration.sefaria.org"' $1
yq e -i '.localSettings.FRONT_END_URL = "https://"+strenv(GIT_COMMIT)+".integration.sefaria.org"' $1

helm upgrade -i $NAME ./helm-chart/sefaria-project --namespace $NAMESPACE -f $1 --debug --timeout=30m0s
helm upgrade -i $NAME ./helm-chart/sefaria --namespace $NAMESPACE -f $1 --debug --timeout=30m0s

2 changes: 1 addition & 1 deletion build/ci/sandbox-helm-deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ yq e -i '.monitor.containerImage.tag = strenv(TAG)' $1
yq e -i '.deployEnv = strenv(NAME)' $1
yq e -i '.localSettings.FRONT_END_URL = "https://"+strenv(NAME)+".cauldron.sefaria.org"' $1

helm upgrade -i $NAME ./helm-chart/sefaria-project --namespace $NAMESPACE -f $1 --debug --timeout=30m0s
helm upgrade -i $NAME ./helm-chart/sefaria --namespace $NAMESPACE -f $1 --debug --timeout=30m0s

File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ spec:
name: local-settings
subPath: local_settings.py
readOnly: true
- mountPath: /google-cloud-secret
name: backup-manager-secret
readOnly: true
command: ["bash"]
args: [
"-c",
Expand All @@ -66,9 +63,6 @@ spec:
items:
- key: local_settings.py
path: local_settings.py
- name: backup-manager-secret # used to access google cloud
secret:
secretName: {{ template "sefaria.secrets.backupManager" . }}
successfulJobsHistoryLimit: 1
failedJobsHistoryLimit: 2
{{- end }}
File renamed without changes.
File renamed without changes.

0 comments on commit 9b6ef8a

Please sign in to comment.