Update for ember 4.12 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
2 times, most recently
from
c4e6c44 to
4eda44b
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
982d5d4 to
91b75b4
Compare
Joeu
reviewed
Jun 25, 2025
Joeu
approved these changes
Jun 26, 2025
AndrewHYi
requested changes
Jul 2, 2025
do not test ember 4.12 in CI due to bug in @ember/string deprecation
…mption error in Ember canary (ember-bootstrap#2027) * Refactor bs-alert to remove @localcopy The `@localCopy` decorate caused issues on Ember canary builds. By refactoring this component to use pure Ember reactivity we can get rid of the decorator. * Allow re-enabling of alert using property after hiding it by clicking
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
bae382d to
25599f6
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
25599f6 to
955519f
Compare
AndrewHYi
approved these changes
Jul 8, 2025
AndrewHYi
added
Needs QA
Gaurav0
added
Ready for Merge
and removed
Needs QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates ember-bootstrap for use in Ember 4.12. It also passes internal tests in Ember 5.4 and Ember 5.8.
It fails tests in Ember 4.12 due to bug in
@ember/stringdeprecation: emberjs/ember.js#20377