fix: preserve generated user ids#6660
Open
MolhamHamwi wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds coverage to ensure createUser does not allow a client-supplied id to override the server-generated one, and updates the implementation to enforce that behavior.
Changes:
- Reorders object spread in
createUserso the generatedidwins overpayload.id - Adds a Node.js test validating
idpreservation and persistence vialistUsers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/api/src/services/userService.js | Ensures server-generated id overrides any client-provided id in the payload |
| apps/api/src/tests/userService.test.js | Adds a regression test verifying createUser ignores payload.id and persists the generated id |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| export async function createUser(payload) { | ||
| const user = { id: `usr_${Date.now()}`, ...payload }; | ||
| const user = { ...payload, id: `usr_${Date.now()}` }; |
Comment on lines
+6
to
+10
| const user = await createUser({ | ||
| id: "usr_client_supplied", | ||
| name: "Payload Name", | ||
| email: "payload@example.com", | ||
| }); |
| assert.equal(user.name, "Payload Name"); | ||
| assert.equal(user.email, "payload@example.com"); | ||
|
|
||
| const stored = (await listUsers()).find((entry) => entry.email === "payload@example.com"); |
| email: "payload@example.com", | ||
| }); | ||
|
|
||
| assert.match(user.id, /^usr_\d+$/); |
Author
|
Addressed the review feedback: user IDs now use randomUUID(), the test resets the user store before each run, uses a unique email, and asserts the semantic ID contract. Local check: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6658
/claim #6658
/claim #743
Test Plan
node --test apps/api/src/tests/userService.test.jsnode --test apps/api/src/tests/*.test.jsgit diff --check