Skip to content

fix: validate and limit search query input#6656

Open
q404365631 wants to merge 2 commits into
SecureBananaLabs:mainfrom
q404365631:fix/search-validation
Open

fix: validate and limit search query input#6656
q404365631 wants to merge 2 commits into
SecureBananaLabs:mainfrom
q404365631:fix/search-validation

Conversation

@q404365631

Copy link
Copy Markdown

Summary

GET /api/search passed req.query.q directly to the search service without validation. An attacker could send extremely long query strings or non-string input.

Changes

  • Add searchQuerySchema in apps/api/src/validators/search.js using Zod
  • Query string is trimmed, length-limited to 200 characters, defaults to empty string
  • Non-string input (e.g. repeated q parameters as array) is rejected
  • Apply schema.parse() in searchController.js

Closes #2833

/claim #2833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search endpoint has no input validation or length limit on query

1 participant