[ShanaBoo] Reject inverted job budget ranges in job validation#6643
Open
genesisrevelationinc-debug wants to merge 9 commits into
Open
[ShanaBoo] Reject inverted job budget ranges in job validation#6643genesisrevelationinc-debug wants to merge 9 commits into
genesisrevelationinc-debug wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Zod validation schemas for Job create/update payloads, including inferred input types and budget range validation.
Changes:
- Introduces
createJobSchemaandupdateJobSchemafor request validation - Adds a refinement to enforce
budgetMax >= budgetMinwhen both are provided - Exports
CreateJobInput/UpdateJobInputinferred types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+38
| export const updateJobSchema = z.object({ | ||
| title: z.string().min(1).max(200).optional(), | ||
| budgetMax: z.number().nonnegative().optional(), | ||
| categoryId: z.string().uuid().optional(), | ||
| skills: z.array(z.string()).optional(), | ||
| }).refine( | ||
| (data) => { | ||
| if (data.budgetMin !== undefined && data.budgetMax !== undefined) { | ||
| return data.budgetMax >= data.budgetMin; | ||
| } | ||
| return true; | ||
| }, | ||
| { | ||
| message: 'budgetMax must be greater than or equal to budgetMin', | ||
| path: ['budgetMax'], | ||
| } | ||
| ); |
| @@ -0,0 +1,41 @@ | |||
| import { z, RefinementCtx } from 'zod'; | |||
Comment on lines
+9
to
+20
| }).refine( | ||
| (data) => { | ||
| if (data.budgetMin !== undefined && data.budgetMax !== undefined) { | ||
| return data.budgetMax >= data.budgetMin; | ||
| } | ||
| return true; | ||
| }, | ||
| { | ||
| message: 'budgetMax must be greater than or equal to budgetMin', | ||
| path: ['budgetMax'], | ||
| } | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShanaBoo Autonomous Fix
This PR was automatically generated by ShanaBoo Earn Engine to claim the $780.00 bounty on this issue.
Source: Github | Task: 4557364252
Closes #2827
Auto-submitted by ShanaBoo CNS — NVIDIA NIM + Microsoft Agent Framework