Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of UX changes + feed component #36

Merged
merged 10 commits into from
Oct 3, 2021
Merged

Conversation

micahlt
Copy link
Member

@micahlt micahlt commented Oct 2, 2021

In this pull request:

  • Better messages
  • Combined user, studio, and project search
  • Feed (aka What's Happening) component for logged in users on the explore page
  • Fixed stretched Itchy logo on auth modal
  • Friendly timestamps for messages
  • Much better UI for project pages
  • Love and favorite projects for logged in users
  • Unread indicators for messages

@micahlt micahlt requested a review from moeenio October 2, 2021 19:56
@micahlt micahlt mentioned this pull request Oct 2, 2021
@micahlt
Copy link
Member Author

micahlt commented Oct 2, 2021

@locness3 I'd really appreciate a review before I merge this, but if you're too busy everything appears to be fine on my end.

@moeenio
Copy link
Member

moeenio commented Oct 3, 2021

@micahlt do you have any apk? I mostly gave up on developement for this project and i don't have an available dev environement.

@micahlt
Copy link
Member Author

micahlt commented Oct 3, 2021

@micahlt do you have any apk? I mostly gave up on developement for this project and i don't have an available dev environement.

Yep - let me zip one up and upload it.

@micahlt
Copy link
Member Author

micahlt commented Oct 3, 2021

Here's the APK inside a zip (GitHub doesn't let me upload straight APK files).

0-8-7.zip

@moeenio
Copy link
Member

moeenio commented Oct 3, 2021

  • Explore page is stuck on infinite loading when signed out, for me.
  • A list with square rounded pictures is IMO not suitable for searching for projects. Thumbnails like on the Explore page should be used (and searching for users/projects/studios should be seperated).
  • Pressing system back button on the project page closes the app (i think that's related to the fact we use modals? Navigation flow with modals #6)
  • IMO, Feed deserves its own tab with more listed items

@moeenio
Copy link
Member

moeenio commented Oct 3, 2021

Also, no way to mark messages as read.

@micahlt
Copy link
Member Author

micahlt commented Oct 3, 2021

  • Explore page is stuck on infinite loading when signed out, for me.

Same problem - thanks for investigating!

  • A list with square rounded pictures is IMO not suitable for searching for projects. Thumbnails like on the Explore page should be used (and searching for users/projects/studios should be seperated).

So just remove the border radius?

That is an issue, but not related to this PR.

  • IMO, Feed deserves its own tab with more listed items

I agree, but again that's a feature that needs to be added later on.

Also, no way to mark messages as read.

Another feature coming soon.

@moeenio
Copy link
Member

moeenio commented Oct 3, 2021

So just remove the border radius?

Well, no :

Thumbnails like on the Explore page should be used (and searching for users/projects/studios should be seperated).

i.e. a Scratch project search shouldn't look like the Contacts app

@micahlt
Copy link
Member Author

micahlt commented Oct 3, 2021

i.e. a Scratch project search shouldn't look like the Contacts app

Ah, I see - okay. Well, that's a much harder thing to do since the ProjectThumbnail (I think that's what I named it) component doesn't take screen width into account. For now, this search will have to do and I'll work on the UI later.

@micahlt
Copy link
Member Author

micahlt commented Oct 3, 2021

All right, everything is working now. Merging!

@micahlt micahlt merged commit 79d067b into Scratch-Client-4:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants