-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add cookies integration #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cookies integration #45
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
18650563 | Triggered | Generic High Entropy Secret | 043d3b3 | scrapegraph-py/examples/miscellaneous/cookies_integration_example.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…a-page-behind-cookies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: SmartScraper Cookie Validation Fails
The cookies
parameter validation in smartScraper
is incomplete. The check typeof cookies === 'object' && cookies !== null
incorrectly accepts arrays, functions, and other non-plain objects, even though the API expects a plain object with key-value pairs. This can lead to unexpected behavior or API errors when invalid types are passed.
scrapegraph-js/src/smartScraper.js#L31-L38
scrapegraph-sdk/scrapegraph-js/src/smartScraper.js
Lines 31 to 38 in 06b6137
if (cookies) { | |
if (typeof cookies === 'object' && cookies !== null) { | |
payload.cookies = cookies; | |
} else { | |
throw new Error('Cookies must be an object with key-value pairs'); | |
} | |
} |
Was this report helpful? Give feedback by reacting with 👍 or 👎
🎉 This PR is included in version 1.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.