-
Notifications
You must be signed in to change notification settings - Fork 9
Pagination integration #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Keyword Argument Mismatch in Crawl Function
A TypeError
occurs at runtime when a test calls client.crawl()
using the keyword argument schema
, because the function's parameter is actually named data_schema
. This leads to a parameter name mismatch.
scrapegraph-py/tests/test_client.py#L242-L243
scrapegraph-sdk/scrapegraph-py/tests/test_client.py
Lines 242 to 243 in 2e477d1
responses.add( | |
responses.POST, |
scrapegraph-py/tests/test_client.py#L266-L267
scrapegraph-sdk/scrapegraph-py/tests/test_client.py
Lines 266 to 267 in 2e477d1
with Client(api_key=mock_api_key) as client: |
scrapegraph-py/tests/test_async_client.py#L614-L615
scrapegraph-py/tests/test_async_client.py#L638-L639
scrapegraph-py/tests/test_async_client.py#L573-L576
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.