Skip to content

Pagination integration #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025
Merged

Pagination integration #44

merged 3 commits into from
Jul 18, 2025

Conversation

VinciGit00
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jul 17, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@VinciGit00
Copy link
Contributor Author

working on my pc
Screenshot 2025-07-17 alle 16 54 42

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Keyword Argument Mismatch in Crawl Function

A TypeError occurs at runtime when a test calls client.crawl() using the keyword argument schema, because the function's parameter is actually named data_schema. This leads to a parameter name mismatch.

scrapegraph-py/tests/test_client.py#L242-L243

responses.add(
responses.POST,

scrapegraph-py/tests/test_client.py#L266-L267

with Client(api_key=mock_api_key) as client:

scrapegraph-py/tests/test_async_client.py#L614-L615

https://github.com/ScrapeGraphAI/scrapegraph-sdk/blob/2e477d1b550a5044e58b8cfab66d70146544e357/scrapegraph-py/tests/test_async_client.py#L614-L615

scrapegraph-py/tests/test_async_client.py#L638-L639

https://github.com/ScrapeGraphAI/scrapegraph-sdk/blob/2e477d1b550a5044e58b8cfab66d70146544e357/scrapegraph-py/tests/test_async_client.py#L638-L639

scrapegraph-py/tests/test_async_client.py#L573-L576

https://github.com/ScrapeGraphAI/scrapegraph-sdk/blob/2e477d1b550a5044e58b8cfab66d70146544e357/scrapegraph-py/tests/test_async_client.py#L573-L576

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Collaborator

@mdehsan873 mdehsan873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinciGit00 VinciGit00 merged commit c99c6d5 into main Jul 18, 2025
5 checks passed
@VinciGit00 VinciGit00 deleted the pagination-integration branch July 18, 2025 17:06
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants