fix: repair bcos formula test block#9
Open
pengshenghai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_filecall in the BCOS formula test block withPathname#write|| truefrom test commands sobrew testdoes not mask failuresversion.to_sinstead of hard-coding1.8.0Scope
This only changes
Formula/bcos.rbtest-block behavior. It does not alter the tarball URL, SHA, install block, package source, or formula metadata.Validation
ruby -c Formula/bcos.rb-> Syntax OKgit diff --check -- Formula/bcos.rb-> passed (Windows line-ending warning only)I could not run
brew testin this Windows workspace because Homebrew is not installed here.AI assistance
Implemented with OpenAI Codex assistance after reading issue #8 and the current formula.