Repository navigation
iOS 27 camera: the still image output takes 420f (N104 asks for a 10-bit still pool) - #371
Draft
claudiusthebot wants to merge 2 commits into
Draft
claudiusthebot wants to merge 2 commits into
claudiusthebot wants to merge 2 commits into
Conversation
… is drawn into xf20 N104's photo formats say UsesPacked10BitFirmwareStillImageOutputPixelFormat. With it, iOS 27.0.1's source node keeps for its still image output only the stream's pixel formats that are 10-bit and full range (-[BWMultiStreamCameraSourceNode _supportedPixelFormatsForOutputID:], 24A446's shared cache, its logic only); the S9's streams offered 420f, 420v and BGRA, so the still image output had no pixel format. camera_refuse.c answers NO to -[FigCaptureSourceVideoFormat usesPacked10BitFirmwareStillImageOutputPixelFormat] (the still image output then takes 420f); cam_still10=1 keeps the plist's answer. camera_formats.c also offers 'xf20' on the StillImage output, and camera_tenbit.c draws a picture into such a pool (made in 8 bits, widened). iOS 16.5's device is unchanged in behaviour. Not run on a phone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The camera's graph on iOS 27 could not start because the still image output had no pixel format.
N104's
AVCaptureSession.plistmarks the photo formats of both cameras (and 1080p, 720p, 1920 x 1440)UsesPacked10BitFirmwareStillImageOutputPixelFormat. With it, iOS 27.0.1's source node (-[BWMultiStreamCameraSourceNode _supportedPixelFormatsForOutputID:], 24A446's shared cache, logic only) keeps for the still image output only the stream's formats that are full range and 10-bit. The S9's streams offered 420f, 420v and BGRA, so none was left.camera_refuse.c:-[FigCaptureSourceVideoFormat usesPacked10BitFirmwareStillImageOutputPixelFormat]answers NO, so the still image output takes 420f like every other output.cam_still10=1keeps the plist's answer.camera_formats.c: the StillImage output also offersxf20.camera_tenbit.cdraws into such a pool: the picture is made in 8 bits into a scratch 420f buffer, then widened.camera_device.c:deliver()takesxf20underHAKIOS_CAMERA_N104only. The 16.5 path is unchanged in behaviour (compiled without N104 to check). The arch-size allowance goes from 1989 to 2006 for this.Built as
cam-n104fmt-17.dylib(sha256de5dc9d42595191dfef19f145d9a611c7bf3e317bc63a7effed9d13c85d623ba) on the build Mac. It is with the phone tester. Not run on a phone yet. This PR stays a draft until the phone test comes back.The talon
npm run preflightlane does not apply: this is scion-kernel, not a talon checkout.tools/arch-check.pypasses locally.🤖 Generated with Claude Code