Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package has quite a few method ambiguities that can get called in practice.
I already tried my hand at resolving some of them.
Things I'm still unsure about:
opnorm
work right now? To me, it seems like the standard way of calling it would result in the ambiguity.+(::SciMLOperators.NullOperator, ::SciMLOperators.AbstractSciMLScalarOperator)
should result in. A matrix operator which is equivalent to a scaled identity matrix?+(::SciMLOperators.AddedOperator, ::SciMLOperators.AbstractSciMLScalarOperator)
https://github.com/SciML/SciMLOperators.jl/actions/runs/7359462846/job/20034274147?pr=230#step:6:300