Fix and re-enable Thermal tests #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Piston test in "Thermal Circuits" is fixed - It is refactored with `mtkmodel` - And, it is moved to a dedicated file as it can be a standalone demo model
- Motor test in "Thermal Circuits" is fixed - It is refactored with `mtkmodel` - And, it is moved to a dedicated file as it can be a standalone demo model
ven-k
force-pushed
the
vkb/thermal-test
branch
from
5aacb6f to
cf325ee
Compare
ven-k
force-pushed
the
vkb/thermal-test
branch
from
cf325ee to
a240a32
Compare
| @@ -0,0 +1,56 @@ | |||
| using ModelingToolkit, OrdinaryDiffEqDefault, Test | |||
There was a problem hiding this comment.
These new files weren't added to runtests? Please fix today or I need to revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Along with related test fixes, Motor and Piston are split out into dedicated files as these can serve as demos.