Skip to content

Conversation

mknaranja
Copy link
Member

@mknaranja mknaranja commented Dec 1, 2021

…fferent levels

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

  • There is at least one issue associated with the pull request.
  • The branch follows the naming conventions as defined in the git workflow.
  • New code adheres with the coding guidelines
  • Tests for new functionality has been added
  • A local test was succesful
  • There is appropriate documentation of your work. (use doxygen style comments)
  • If new third party software is used, did you pay attention to its license? Please remember to add it to the wiki after successful merging.
  • If new mathematical methods or epidemiological terms are used, has the glossary been updated ? Did you provide further documentation ?
    is present or referenced. Please provide your references.
  • The following questions are addressed in the documentation*: Developers (what did you do?, how can it be maintained?), For users (how to use your work?), For admins (how to install and configure your work?)
  • For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request.
  • Coverage report for new code is acceptable.

Closes #135

@mknaranja mknaranja added class::feature A feature to be implemented for some part of the software status::in progress This issue is in progess. loc::backend This issue concerns the C++ backend implementation. loc::data analysis This issue concerns any kind of data analysis. model::ode This issue concerns any kind of ODE-based model. labels Dec 1, 2021
@mknaranja mknaranja requested a review from dabele December 1, 2021 17:49
@mknaranja mknaranja self-assigned this Dec 1, 2021
@mknaranja
Copy link
Member Author

@dabele This is very basic but may be helpful nevertheless.

@mknaranja mknaranja changed the title 135 Simple tool to compute contact reduction from reduction factors of di… WIP: 135 Simple tool to compute contact reduction from reduction factors of di… Dec 13, 2021
@dabele dabele marked this pull request as draft April 7, 2022 15:00
@dabele dabele changed the title WIP: 135 Simple tool to compute contact reduction from reduction factors of di… 135 Simple tool to compute contact reduction from reduction factors of di… Apr 7, 2022
@mknaranja
Copy link
Member Author

mknaranja commented May 12, 2022

@HenrZu (Please see ##284) I'll also do the review but if you have some time, try to understand the functionality with help of our first paper ;)

@mknaranja
Copy link
Member Author

@DavidKerkmann If you are finished, please mark it as "ready for review" :)

@DavidKerkmann
Copy link
Member

DavidKerkmann commented May 12, 2022

@DavidKerkmann If you are finished, please mark it as "ready for review" :)

Where exactly? I think I marked the pull request as ready. I worked on a new branch since this one was quite old and possibly outdated and made a new pull request.

@dabele
Copy link
Member

dabele commented May 12, 2022

The new one:
#284
Closing this PR.

@dabele dabele closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class::feature A feature to be implemented for some part of the software loc::backend This issue concerns the C++ backend implementation. loc::data analysis This issue concerns any kind of data analysis. model::ode This issue concerns any kind of ODE-based model. status::in progress This issue is in progess.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tool to compute NPI contact reduction
3 participants