fix: add inline validation for invalid characters in login and signup #8912
Open
akshatsinghai6682-sketch wants to merge 1 commit into
Open
fix: add inline validation for invalid characters in login and signup #8912akshatsinghai6682-sketch wants to merge 1 commit into
akshatsinghai6682-sketch wants to merge 1 commit into
Conversation
… forms Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
Contributor
|
@akshatsinghai6682-sketch is attempting to deploy a commit to the sandeepvashishtha's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
bug
github-actions
Bot
added
gssoc:approved
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
There was a problem hiding this comment.
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| LoginForm.js | 9.18 → 10.00 | Complex Method |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added inline validation for invalid characters in the Username/Email field on the Login page and First Name, Last Name, and Email fields on the Signup page.
Previously, entering invalid characters like ;;;; or ,,,, only showed a generic banner error after form submission with no field-level feedback. Now users get real-time inline warnings directly below the respective field as they type.
Fixes #8899
Type of change
Bug fix (non-breaking change which fixes an issue)
Screenshots / Video (if applicable)
Typing ;;;; in Username field → inline warning appears
Signup form name fields showing inline error for special characters
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have run local unit tests using npm test and verified they pass
I have run npm run lint and resolved any new errors or warnings
I have verified responsiveness and visual alignment on desktop and mobile viewports