Bug: Search bar input locked; new keystrokes instantly disappear on typing or backspace#8909
Bug: Search bar input locked; new keystrokes instantly disappear on typing or backspace#8909Avani176 wants to merge 2 commits into
Conversation
|
@Avani176 is attempting to deploy a commit to the sandeepvashishtha's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc:approved
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
(2 files improve in Code Health)
Gates Failed
(1 file with Complex Method)
Our agent can fix these. Install it.
Gates Passed
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| ModernSearchInput.js | 1 advisory rule | 9.49 → 9.41 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| Hero.js | 8.40 → 10.00 | Complex Method |
| SearchFilter.js | 8.13 → 9.50 | Complex Method |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
| <<<<<<< HEAD | ||
| ref={searchInputRef} | ||
| type="text" | ||
| placeholder={tags && tags.length > 0 ? "" : placeholder} | ||
| // UPDATED CLASSNAME BELOW: Added text-black and dark:text-white explicitly to the input field | ||
| className="flex-1 bg-transparent border-none outline-none text-black dark:text-white min-w-[120px] placeholder-gray-400 dark:placeholder-gray-500" | ||
| // UPDATED PROPERTY BELOW: Added spellCheck="false" to prevent the full-height red spellcheck lines | ||
| spellCheck="false" | ||
| value={value} | ||
| onChange={onChange} | ||
| onFocus={handleFocus} | ||
| autoFocus={autoFocus} | ||
| onBlur={handleBlur} | ||
| onKeyDown={onKeyDown} | ||
| /> | ||
| ======= |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
ModernSearchInput increases in cyclomatic complexity from 12 to 14, threshold = 9
1 participant
...croll hook
Description
This PR resolves multiple UI and system stability issues related to the search and landing experience:
text-black dark:text-whitesupport and includedspellCheck="false"to prevent browser native spelling underscores from clipping the layout.ReferenceError: scrollYProgress is not definedruntime crash in the Hero component by properly declaring and invoking theuseScrollhook fromframer-motion.Fixes #8548
Type of change
Screenshots / Video (if applicable)
Feel free to drag and drop your frontend screenshots here if you want to show the working UI!
Checklist