Made application text optional #1675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemisis84
requested review from
Mathias-a,
robines and
Snorre98
as code owners
nemisis84
commented
Feb 6, 2025
| @@ -67,6 +67,8 @@ export function RecruitmentPositionForm({ initialData, positionId, recruitmentId | |||
| gang: { id: Number.parseInt(gangId ?? '') }, | |||
| recruitment: recruitmentId ?? '', | |||
| interviewer_ids: data.interviewer_ids || [], | |||
| default_application_letter_nb: data.default_application_letter_nb || '', | |||
There was a problem hiding this comment.
Need to pass in empty string if non is provided such that OPTIONAL_NON_EMPTY_STRING accepts it
Snorre98
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This should be optional
Fix:
Made field optional in backend. Added export const OPTIONAL_NON_EMPTY_STRING to schema/strings which can be used when strings are optional.