[WIP] Fix typecheck errors and add theme system tests#139
Draft
Copilot wants to merge 4 commits into
Draft
Conversation
…with mergeThemeProps - Updated all component files to use mergeThemeProps helper instead of spreading overrides - Fixed type widening issue where 'as const' literals were being overridden by string types - Updated useThemeResolver types to return ResolvedOverrideProps instead of OverrideProps - Added index signature to ResolvedOverrideProps to support dynamic properties - Fixed components: * ChatMessage.vue (8 instances) * ChatSettingsPopover.vue (4 instances) * SystemPromptsModal.vue (3 instances) * WorkflowChatMessage.vue (2 instances) * ColorPaletteSection.vue (2 instances) * NotificationBell.vue * SideBottomNav.vue (4 instances) * SidebarAuthButton.vue * SidebarAuthButtonClerk.client.vue * SidebarProjectTree.vue (5 instances) * SideNavContentCollapsed.vue (4 instances) * WorkspaceBackupApp.vue (5 instances) * PageShell.vue * ChatContainer.vue * GalleryGrid.vue (2 instances) All originally mentioned files now pass typecheck with 0 errors.
Co-authored-by: Saluana <46250649+Saluana@users.noreply.github.com>
Co-authored-by: Saluana <46250649+Saluana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeCheck & Test Fix Plan
Phase 1: Analysis & Review ✅
Root Causes Found:
OverridePropsspread AFTERas constliterals widens typesapp.config.tsfiles causing conflicting themesimport.meta.hotmissing Vite typesSSR_AUTH_ENABLED=truerequiring secretsconvexconfig not typed in nuxt.config.tsOverridePropsindex signature too permissivePhase 2: Fix Core Type Issues (In Progress)
mergeThemePropshelper function to preserve literal typescleanThemePropshelper to remove debug propsOverridePropsto safe keys only (removed index signature)/app.config.tsfileimport.meta.hottyping in compiler-core.tsProgress: 99 → 69 errors (30 fixed, 39% reduction)
Phase 3: Address Code Review Issues
Phase 4: Write E2E Tests
Phase 5: Validation
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.