-
Notifications
You must be signed in to change notification settings - Fork 31
feat: drag and drop from palette @W-19284238 #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjuraschik
merged 12 commits into
SalesforceCommerceCloud:feature/design-layer-integration
from
rfding:feat/palette-drag-and-drop
Oct 23, 2025
Merged
feat: drag and drop from palette @W-19284238 #226
mjuraschik
merged 12 commits into
SalesforceCommerceCloud:feature/design-layer-integration
from
rfding:feat/palette-drag-and-drop
Oct 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rfding
commented
Oct 9, 2025
- Introduces 3 new hooks: useExternalDragHandler, useExternalDragInteraction, useRegionDecoratorClasses
- Adds support to regions so that css classes are added when something is dragged over them
- These changes are meant to support dragging components in from the palette in Page Designer
0085657 to
0c6e72c
Compare
0c6e72c to
dc803ad
Compare
dc803ad to
8d38f68
Compare
8d38f68 to
3ddf60b
Compare
mjuraschik
approved these changes
Oct 23, 2025
5d2635e
into
SalesforceCommerceCloud:feature/design-layer-integration
4 checks passed
steelsojka
added a commit
to steelsojka/commerce-sdk-isomorphic
that referenced
this pull request
Oct 27, 2025
…on' into feature/drag-and-drop-move * upstream/feature/design-layer-integration: feat: drag and drop from palette @W-19284238 (SalesforceCommerceCloud#226) bump size
steelsojka
added a commit
to steelsojka/commerce-sdk-isomorphic
that referenced
this pull request
Oct 27, 2025
…on' into feature/drag-and-drop-move * upstream/feature/design-layer-integration: feat: drag and drop from palette @W-19284238 (SalesforceCommerceCloud#226) bump size
steelsojka
added a commit
that referenced
this pull request
Oct 28, 2025
feat(design): move design components out of sdk feat(design): add messaging api fix types upgrade typescript to support esm modules cleanup messenger on disconnect make scrolling isomorphic feat(design): add hover bounds events (#220) feat: refine connection logic for design layer feat(pd): add design context and wrapper @W-19432252 (#222) * feat(pd): add design context and wrapper feat(design): add more interactions and cleanup (#223) feat: drag and drop from palette @W-19284238 (#226) * feature(design): add drag and drop support for regions * rework drag and drop * add local dragging logic * add drop target styles * fix styles * fix decorator render order * feat: add unit test + build fixes * fix: styling * fix: nodeToTargetMap being empty + update tests * fix: add back region green border * fix: test + bad css merge * fix: region decorator tests --------- Co-authored-by: Steven Sojka <[email protected]> Feature/drag and drop move (#237) * feature(design): add drag and drop support for regions * rework drag and drop * add local dragging logic * add drop target styles * fix styles * fix decorator render order * polish move * get parent id from context update styles and add design tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.