feat: handle missing final_info.json after successful experiment runs#219
Open
chun61205 wants to merge 2 commits intoSakanaAI:mainfrom
Open
feat: handle missing final_info.json after successful experiment runs#219chun61205 wants to merge 2 commits intoSakanaAI:mainfrom
chun61205 wants to merge 2 commits intoSakanaAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using
run_experiment, I discovered that even if the experiment completes successfully, the script will crash if the output file is not namedfinal_info.json. This happens because the postprocessing logic assumes the presence of this file:AI-Scientist/ai_scientist/perform_experiments.py
Lines 61 to 66 in 9dffdc4
Therefore, this pr
final_info.jsonafter a successful experiment run.experiment.pymust generatefinal_info.json.