This repository has been archived by the owner on Mar 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
ready for comps #12
Open
thetaspirit
wants to merge
53
commits into
master
Choose a base branch
from
config-test-merge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ready for comps #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re inaccurateRobot.java has the dimensions of the comp bot
which makes sense because the previous commit says the comp configs are inaccurate lol
arms and heading pids re-tuned arms target angles set
Task has not been tested the fullInPosition is zero and the other positions are set relative to that
plan to: merge the package organization branch with this one add other arms encoder reset task double check some more stuff
has not been calibrated or tested
honestly, this stuff will probalby need retuning again soon
calibrated arms (again)
Opportunitree is the comp bot Curiositree is the test bot
added DetatchPannel task has not been tested
…ShoppingKart2019 into comp-bot-configs
Summary of the changes: - robotInit now loads a config file first. If a jumper is present on the specified digital input, the test config will be loaded. - Motors and Sensors are no longer abstract, and initialize all motors using the values from the passed in config. - TurnConfiguration has been deleted and replaced with PidConfig - All tasks using PID controllers were updated to take a PidConfig object as an argument. - Robot.instance was removed, and all tasks were updated to take all needed inputs in the constructors.
implemented the robot.location fields in robot.java
works for drive practice
deploys and drives/operates
…/ShoppingKart2019 into config-test-merge
arms position upon deploy is now customizable using an xbox controller with opperator board has a few extra features DetatchPannel has not officially been tested (or tuned) hatch heights 2 and 3 have not been calibrated
…useIHopetoDeleteItTonight' into config-test-merge
captainrex493
previously approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe have one more person look through this because it is very large.
There are a lot of commits for this branch. Would it be a good idea to have multiple commits? The easiest thing to do would be to rebase, but this commit history here is a bit messy. |
tarasirosh
previously approved these changes
Mar 8, 2019
reacrtivated boost (rightTrigger() > .5) changed drive and turn gain to .75
Lift throttling kicker backpass (commented out) Fixed competition presets
Patch Harder
Patch Harder
thetaspirit
dismissed stale reviews from tarasirosh and captainrex493
via
March 16, 2019 00:03
e06ad86
added feature: right trigger makes robot drive straight backwards
* calibrated vision trgets to comp field * lowered lift throttle, recalibrated arms, no change in Robot besides formatting * decreased arm pid output range * decreased heading pid output range, lowered turn gain * lowered max lift height with encoder * decreased distance output range * added boost to full speed for drive (left bumper) * added lower limit to lift if the encoder ever reads less than 17 inches, the lift is stopped * update lift upper limit lift can go about eight inches higher now * calibrated lift presets Glacier Peak (practice field) and calibrated arms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that there are a few features that have not been tested, but most of them are presets
this branch can entirely replace master. when you merge, it probably will
it's game time