Skip to content
This repository has been archived by the owner on Mar 5, 2022. It is now read-only.

ready for comps #12

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

ready for comps #12

wants to merge 53 commits into from

Conversation

thetaspirit
Copy link
Contributor

@thetaspirit thetaspirit commented Mar 7, 2019

note that there are a few features that have not been tested, but most of them are presets

this branch can entirely replace master. when you merge, it probably will

it's game time

thetaspirit and others added 30 commits February 16, 2019 17:25
…re inaccurateRobot.java has the dimensions of the comp bot
which makes sense because the previous commit says the comp configs are
inaccurate lol
arms and heading pids re-tuned
arms target angles set
Task has not been tested
the fullInPosition is zero
and the other positions are set relative to that
plan to:
merge the package organization branch with this one
add other arms encoder reset task
double check some more stuff
has not been calibrated or tested
honestly, this stuff will probalby need retuning again soon
Opportunitree is the comp bot
Curiositree is the test bot
added DetatchPannel task
has not been tested
Summary of the changes:
    - robotInit now loads a config file first. If a jumper is
      present on the specified digital input, the test config
      will be loaded.
    - Motors and Sensors are no longer abstract, and initialize
      all motors using the values from the passed in config.
    - TurnConfiguration has been deleted and replaced with PidConfig
    - All tasks using PID controllers were updated to take a
      PidConfig object as an argument.
    - Robot.instance was removed, and all tasks were updated to
      take all needed inputs in the constructors.
implemented the robot.location fields in robot.java
deploys and drives/operates
captainrex493
captainrex493 previously approved these changes Mar 7, 2019
Copy link
Contributor

@captainrex493 captainrex493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe have one more person look through this because it is very large.

@thetaspirit
Copy link
Contributor Author

There are a lot of commits for this branch. Would it be a good idea to have multiple commits? The easiest thing to do would be to rebase, but this commit history here is a bit messy.

@thetaspirit thetaspirit requested a review from tarasirosh March 7, 2019 16:51
tarasirosh
tarasirosh previously approved these changes Mar 8, 2019
reacrtivated boost (rightTrigger() > .5)
changed drive and turn gain to .75
Lift throttling
kicker backpass (commented out)
Fixed competition presets
@thetaspirit thetaspirit dismissed stale reviews from tarasirosh and captainrex493 via e06ad86 March 16, 2019 00:03
captainrex493 and others added 5 commits March 18, 2019 17:13
added feature:
right trigger makes robot drive straight backwards
* calibrated vision trgets to comp field

* lowered lift throttle, recalibrated arms, no change in Robot besides formatting

* decreased arm pid output range

* decreased heading pid output range, lowered turn gain

* lowered max lift height with encoder

* decreased distance output range

* added boost to full speed for drive (left bumper)

* added lower limit to lift

if the encoder ever reads less than 17 inches, the lift is stopped

* update lift upper limit

lift can go about eight inches higher now

* calibrated lift presets

Glacier Peak (practice field)
and calibrated arms
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants