fix(layout): open rooms on iPad using 'Request Desktop Website'#810
Closed
Just-Insane wants to merge 5 commits into
Closed
fix(layout): open rooms on iPad using 'Request Desktop Website'#810Just-Insane wants to merge 5 commits into
Just-Insane wants to merge 5 commits into
Conversation
iPadOS 13+ Safari reports a macOS user-agent by default, so ua-parser-js sees os.name === 'Mac OS' and leaves device.type unset. mobileOrTablet() already handles this via maxTouchPoints > 1, but three layout gates only checked screenSize === ScreenSize.Mobile (which is width-based, so a full-width iPad reads as Desktop or Tablet): - MobileFriendlyPageNav: hides the sidebar when a room is active - MobileFriendlyClientNav: hides the app nav bar when deep in a route - createRouter: adds a WelcomePage index route instead of an empty outlet - PageRoot: suppresses the vertical divider line between nav and content All four now also check mobileOrTablet() so iPads in desktop-UA mode get the correct single-panel navigation behaviour.
dozro
requested changes
May 14, 2026
Member
dozro
left a comment
dozro
left a comment
There was a problem hiding this comment.
you're missing the AI checkboxes in the PR description
Replaces mobileOrTablet() with mobileOrTabletLayout() for all layout decisions in Home, Direct, Space, Explore, and Inbox page components. mobileOrTablet() returns true for all tablets (including iPad with native UA or 'Request Desktop Website'), so isMobile was true on iPad, causing the room list nav to render at width 100% with no resize handle — giving a broken half-layout where the sidebar took the full width. mobileOrTabletLayout() is true only for phone-form-factor devices, so tablets always get the fixed-width desktop sidebar and SidebarResizer. Space.tsx retains mobileOrTablet() for the swipe-to-room touch gesture, which is appropriate for all touch devices including tablets.
6 tasks
This was referenced May 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #836 — consolidated with #811, #812, #813, #828, #829 into a single mobile/iOS/iPad PR.