Now looking for translators!

@benjaminvdb

A lot of people have asked for translations and stated their willingness to help translating, so I'm happy to announce that we finally have an infrastructure in place to make translations as seamless as possible. Head over to Sabaki I18n to see how you can contribute.

To avoid duplicate work in the beginning, I suggest everyone who wants to start translating to comment with their language on this thread, so I can put them in this table:

Language	Translator	PR status
Dutch	@benjaminvdb	In Progress
German	@Gargantuar314	In Progress
Brazilian Portuguese	@joaomarcuslf2	Merged

A big thanks to all the translators in advance!

I almost finished Simplified Chinese
https://github.com/geovens/sabaki-i18n/blob/master/src/zh-Hans.i18n.js
but I have some questions:

Many translated strings in preferences are not shown?
Things like ${appName}, ${author} are not replaced?
Are hotspots just bookmarks?
What does 'fork' mean in navigation menu?
What does 'move colorization' mean in view menu?
Does 'zoom' in tools menu only affect game tree?
Where does 'unclear position' or 'even position' show? Do they mean 'who will win is unclear' and 'black and white seems to have even chance to win'?
What does 'instantly play out analysis variations on board' do?
What does 'show automatic move titles' do?
There are multiple strings of 'All Files'. Where are they shown?
Where is AdvancedPropertiesDrawer?
What does 'update result' in score drawer do?

@geovens

@geovens Thanks for your work! I put you on the list for Simplified Chinese.

Thanks for the report, I'll try to fix it. In the meantime, you can toggle the Preferences checkboxes to update the strings manually.
Please look at the model translation file en.i18n.js as how to handle interpolation. You can't just specify a string, but a function like this:

'${appName} v${version}': p => `${p.appName} v${p.version}`

Yes, but the specification calls thems hotspots, because the hotspot move should show "something interesting (e.g. node contains a game-deciding move)."
A fork is a node where the game splits into multiple variations.
If you annotate a move as 'good', 'interesting', 'doubtful', or 'bad', it will appear on the board with the colors green, blue, purple, or red if the setting is activated.
No 'Zoom' affects the whole interface.
If you annotate a move, it will be shown in the comments section as an icon. The text 'Unclear Position', etc. will be shown as tooltip.
In engine analysis mode, if you hover on a stone, it will show the whole variation at once instead of playing the variation stone by stone if the setting is activated.
For each move we generate a move title based on the move, e.g. 'Hane', 'One-Point Jump', 'Chinese Fuseki', etc. if the setting is activated.#
Usually 'All Files' is shown in the open file dialog as an option for the extension filter.
In the main menu, choose 'Tools' > 'Open SGF Properties...' to open the AdvancedPropertiesDrawer.
'Update Result' will write the end score into the SGF file.

I've completed most of the Korean translation:

https://github.com/isty2e/sabaki-i18n/blob/korean/src/ko.i18n.js

However, some go terms like "Dog's head" are not well defined in Korean and I think there is no proper jargon to describe such shapes. What is your recommendation?

Thanks for your work! Not sure, either don't translate and fall back to English, or specify a string with a space character in it, so it doesn't fall back to English?

Then I'll let it fall back to English. Somebody might find an adequate translation, and I feel like leaving them as blank is not a good idea.

Fix non-engine player name tooltip

The 'Load Language File' feature is just a convenience. Not all strings can be replaced on runtime. For the actual language switching, the user will be required to restart Sabaki.

Make 'Score' translatable

@af990m

While I made some changes in my translation, I also noticed that @af990m forked the repo again from my fork, and had made changes too. I believe that many of their changes are better than mine. So I guess af990m could consider check my last two commits as revision suggestions, merge them into theirs, and the main repo could merge from af990m's repo?

@geovens

@geovens The result you submitted is very good！Although I used the same shortcut as the English version, but it detracts from the aesthetics of the interface. :(
It's hard to compare which is better, so please ignore my PR. :)

Label for unnamed engines in engines menu

I made a conversion from simplified to traditional
https://github.com/af990m/sabaki-i18n/blob/master/src/zh-Hant.i18n.js

I think these should be the system strings of keyboard shortcuts. If they're not correct, you should probably open a bug on Electron, or even Chromium.

I just noticed that (I probably had done it before and then forgot) you can generate more than one move using the Generate Move command as following:

Start a new handicapped game with at least 2 stones, and assign white player to a bot. The game would not start until Generate Move was invoked, after black responded, white will continue to generate the next move.

line 107 and 260 Generate move is not exactly 讓引擎走一手, because the engine will continue to generate moves afterward. How about 讓引擎走棋?

I don't know engine could continue to generate moves afterward. It has always been just one move for me. When does it generate multiple moves?

This is the consequence of assigning an engine to a player. Sabaki will automatically generate a move for an engine if it is assigned to a player. But clicking on 'Generate Move' will only generate one move; it will not initiate an engine vs. engine or engine vs. player game.

Attaching an engine and not assigning it to a player, clicking on 'Generate Move' will not let the engine continue generating moves after you respond.

I'm working on the French translation... Thank you all for your great work.

I would like to contribute for the German translation, although I don't know a lot of the German terms.

@Gargantuar314

@Gargantuar314 There's no need to provide a complete translation. Just do what you can and hopefully someone else can contribute to it. It's a community effort, after all!

Hi all! I'll gladly start working on the complete Spanish translation. Cheers!

Hi! I can contribute with Brazilian portuguese, can I create the branch?

Sure, thanks a lot, I'll add you to the list.

Fix non-engine player name tooltip

Make 'Score' translatable

Label for unnamed engines in engines menu

Fix non-engine player name tooltip

Make 'Score' translatable

Label for unnamed engines in engines menu

Navigation Menu

Now looking for translators! #647

27 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Now looking for translators! #647

Description

Activity

geovens commented on Mar 15, 2020

yishn commented on Mar 15, 2020

isty2e commented on Mar 15, 2020

yishn commented on Mar 15, 2020

isty2e commented on Mar 15, 2020

yishn commented on Mar 15, 2020

geovens commented on Mar 16, 2020

af990m commented on Mar 16, 2020

af990m commented on Mar 16, 2020

27 remaining items

yishn commented on Mar 22, 2020

yauwing commented on Mar 24, 2020

yishn commented on Mar 24, 2020

romton843 commented on Apr 8, 2020

Gargantuar314 commented on Apr 17, 2020

yishn commented on Apr 17, 2020

mlopezviedma commented on Apr 17, 2020

joaomarcuslf commented on Jun 22, 2020

yishn commented on Jun 22, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions