Remove not used terraform variables about registration #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove variables that are not used in terraform. All of them are about configurations now managed by Ansible, like registration and SID.
Reintroduce sentence deleted by mistake.
mpagot
commented
Jan 22, 2025
| @@ -168,7 +168,7 @@ Internally to the subnet, all traffic is allowed. | |||
|
|
|||
| By default, this configuration creates 3 instances in AWS: one for support services (mainly iSCSI as most other services - DHCP, NTP, etc - are provided by Amazon) and 2 cluster nodes, but this can be changed to deploy more cluster nodes as needed. | |||
|
|
|||
| Once the infrastructure is created by Terraform, the servers are provisioned with Ansible. | |||
| Once the infrastructure is created by Terraform, the servers can be provisioned with Ansible. | |||
There was a problem hiding this comment.
It is not something under Terraform control. It is not Terraform running Ansible (as it was at the time Ansible was Salt). This is the same reason that allow to delete all the unused terraform variables.
mpagot
commented
Jan 22, 2025
| @@ -152,24 +144,6 @@ module "drbd_node" { | |||
| nfs_export_name = var.netweaver_sid | |||
| } | |||
|
|
|||
| module "iscsi_server" { | |||
There was a problem hiding this comment.
Just change order to use more similar structure to Azure main.tf file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove variables that are not used in terraform. All of them are about configurations now managed by Ansible, like registration and SID.
Verification
Azure
AWS
GCP