instance_list template: Fix filter button to use bootstrap5 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 78.83% 79.61% +0.78%
==========================================
Files 21 21
Lines 1658 1628 -30
==========================================
- Hits 1307 1296 -11
+ Misses 351 332 -19 ☔ View full report in Codecov by Sentry. |
mimi1vx
approved these changes
Jan 6, 2025
|
LGTM , I would like to know if there was some real check that really works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading the application to Django5 and Bootstrap5, the "Edit filter" button became unresponsive. This is because the template is still using Bootstrap4.
Related ticket: https://progress.opensuse.org/issues/173848