Support for Locales, On and array init comprehension#6
Merged
SAtacker merged 4 commits intoSTEllAR-GROUP:mainfrom Sep 14, 2025
Merged
Support for Locales, On and array init comprehension#6SAtacker merged 4 commits intoSTEllAR-GROUP:mainfrom
SAtacker merged 4 commits intoSTEllAR-GROUP:mainfrom
Conversation
This patch adds support for Chapel’s “array init with for-loop” syntax, e.g.: var arr: [0..2] int = for i in 0..2 do i+1; Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
Added additional tests to check the same Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
* Add support for writeln function - Also fix string literals being injected into last function call Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Add numLocale support Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Complete adding here.id Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Complete numLocales and Locales array of type locale Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Fix index comparison for array kind - Use programatic index instead of predefined index of variant type as it was bound to change Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Cleanup: remove informal debug helpers Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Remove unused headers,functions for debugging purposes Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Remove unnecessary changes Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Fix forLoopExpression over locales Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Interpret any DOT method as a function call Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Complete On functionality Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Add a bit broken support to on Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Seems to work now - On expression tracks the variables down up Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Modify test expected output Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Add zipped iterator for forall and fix multiple statement inside On Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Add support for chapel zip and in-loop tuple variables Add forall support for zip unpacked Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Fix the codegen for On - The correct condition for appending On variables is symbolTableRef->id >= varsym->scopeId Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Fix everything for On and its scoping Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Fix generation of left << and right >> ops Also fix some stray function assignments Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Fix adding variables to On lambda - Correct condition: varsym->scopeId < currentOnExpr->scopeId - Current issue: We cannot pass non-serializable objects like chplx::Array Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Prevent inlinecxx from being added to On arguments Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Add a debug console output Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Set FMT_INSTAL even for header only Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> * Minimal contributing guide Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com> --------- Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
SAtacker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.