Skip to content

Unwrap array iterators to pointers, if possible #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hkaiser wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Unwrap array iterators to pointers, if possible #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a0b828a
Adding overloads taking a source_location to all APIs that spawn new …
hkaiser Sep 2, 2023
2e1cdf0
Merge pull request #56 from STEllAR-GROUP/source_location
ct-clmsn Sep 3, 2023
5ef04b3
updated codegenerator
ct-clmsn Sep 3, 2023
246d164
udpated good files
ct-clmsn Sep 3, 2023
736e234
Merge pull request #57 from ct-clmsn/compiler-srcloc
ct-clmsn Sep 3, 2023
1765c90
rollback on forLoop
ct-clmsn Sep 3, 2023
2f62ed8
Merge pull request #58 from ct-clmsn/compiler-srcloc
ct-clmsn Sep 3, 2023
778b44d
rollingback codegen modification on
ct-clmsn Sep 3, 2023
a8c9b23
Merge pull request #59 from ct-clmsn/compiler-srcloc
ct-clmsn Sep 3, 2023
6192865
spacing issue in validation file
ct-clmsn Sep 3, 2023
018a47b
Merge pull request #60 from ct-clmsn/compiler-srcloc
ct-clmsn Sep 3, 2023
61b297a
fixed overaggressive replace regex
ct-clmsn Sep 3, 2023
415d38d
Merge pull request #61 from ct-clmsn/compiler-srcloc
ct-clmsn Sep 3, 2023
717f3a1
fixed formatting w/clang-format
ct-clmsn Sep 4, 2023
0a5db92
Merge pull request #62 from ct-clmsn/compiler-srcloc
ct-clmsn Sep 4, 2023
3e1dd50
Merge pull request #65 from ct-clmsn/paper_patches
ct-clmsn Sep 24, 2023
74b6384
Merge branch 'main' of github.com:STEllAR-GROUP/chplx
hkaiser Jun 28, 2025
f624a31
Unwrap array iterators to pointers, if possible
hkaiser Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/src/codegenvisitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ struct StatementVisitor {
//auto const& rk = std::get<std::shared_ptr<range_kind>>(node->indexSet.kind);
//auto & indices = rk->args;

os << "chplx::forall(chplx::Range{";
os << "chplx::forall(HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{";

if(node->indexSet.size() == 1) {
ExprVisitor ev{os};
Expand Down Expand Up @@ -686,7 +686,7 @@ struct StatementVisitor {
//auto const& rk = std::get<std::shared_ptr<range_kind>>(node->indexSet.kind);
//auto & indices = rk->args;

os << "chplx::coforall(chplx::Range{";
os << "chplx::coforall(HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{";
/*
if(std::holds_alternative<int_kind>(indices[0].kind)) {
os << int_kind::value(indices[0].literal[0]);
Expand Down
51 changes: 29 additions & 22 deletions backend/test/forall/forall.cpp.good
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ namespace forall {
B(i) = 1.000000;
});
#line 43 "forall.chpl"
chplx::forall(chplx::Range{0, 9}, [&](auto i) {
chplx::forall(
HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{0, 9}, [&](auto i) {
#line 44 "forall.chpl"
B(i) = 1.000000;
});
B(i) = 1.000000;
});
};

void __thisModule::__main()
Expand All @@ -43,20 +44,22 @@ namespace forall {
std::cout << i << std::endl;
});
#line 16 "forall.chpl"
chplx::forall(chplx::Range{0, 10}, [&](auto i) {
chplx::forall(
HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{0, 10}, [&](auto i) {
#line 17 "forall.chpl"
std::cout << i << std::endl;
});
std::cout << i << std::endl;
});
#line 20 "forall.chpl"
chplx::forLoop(chplx::Range{0, N}, [&](auto i) {
#line 21 "forall.chpl"
std::cout << i << std::endl;
});
#line 24 "forall.chpl"
chplx::forall(chplx::Range{0, N}, [&](auto i) {
chplx::forall(
HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{0, N}, [&](auto i) {
#line 25 "forall.chpl"
std::cout << i << std::endl;
});
std::cout << i << std::endl;
});
#line 28 "forall.chpl"
chplx::forLoop(chplx::Range{0, N + 1}, [&](auto i) {
#line 29 "forall.chpl"
Expand All @@ -65,29 +68,32 @@ namespace forall {
std::cout << i << std::endl;
});
#line 33 "forall.chpl"
chplx::forall(chplx::Range{0, N + 1}, [&](auto i) {
chplx::forall(
HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{0, N + 1}, [&](auto i) {
#line 34 "forall.chpl"
A(i) = 1.000000;
A(i) = 1.000000;
#line 35 "forall.chpl"
std::cout << i << std::endl;
});
std::cout << i << std::endl;
});
#line 48 "forall.chpl"
chplx::forLoop(chplx::Range{0, 9}, [&](auto i) {
#line 49 "forall.chpl"
A(i) = i;
});
#line 51 "forall.chpl"
chplx::forall(chplx::Range{0, 9}, [&](auto i) {
chplx::forall(
HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{0, 9}, [&](auto i) {
#line 52 "forall.chpl"
A(i) = i;
});
A(i) = i;
});
#line 54 "forall.chpl"
chplx::Array<std::int64_t, chplx::Domain<1>> B(chplx::Range(0, 2));
#line 56 "forall.chpl"
chplx::coforall(chplx::Range{0, 2}, [&](auto tid) {
chplx::coforall(
HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{0, 2}, [&](auto tid) {
#line 57 "forall.chpl"
B(tid) = tid;
});
B(tid) = tid;
});
#line 60 "forall.chpl"
chplx::forLoop(chplx::Range{0, 2}, [&](auto i) {
#line 61 "forall.chpl"
Expand All @@ -96,10 +102,11 @@ namespace forall {
#line 63 "forall.chpl"
chplx::Array<std::int64_t, chplx::Domain<1>> C(chplx::Range(0, 2));
#line 64 "forall.chpl"
chplx::coforall(chplx::Range{0, 2}, [&](auto tid) {
chplx::coforall(
HPX_CURRENT_SOURCE_LOCATION(), chplx::Range{0, 2}, [&](auto tid) {
#line 65 "forall.chpl"
C(tid) = tid;
});
C(tid) = tid;
});
#line 67 "forall.chpl"
chplx::forLoop(chplx::Range{0, 2}, [&](auto i) {
#line 68 "forall.chpl"
Expand Down
Loading
Loading