Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Drag disabled there is no need to prevent default. #616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

With Drag disabled there is no need to prevent default. #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1665fa1
Removing dragstart default behaviour only if mouseDrag is enabled.
Jan 22, 2024
d5b0692
Removing dragstart default behaviour only if mouseDrag is enabled.
Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
16.20.2
6 changes: 3 additions & 3 deletions dist/vue-carousel.min.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@
"description": "A flexible, responsive, touch-friendly carousel for Vue.js",
"main": "dist/vue-carousel.min.js",
"scripts": {
"build": "webpack --config webpack.prod.js && npm run updateDocAssets",
"build": "export NODE_OPTIONS=--openssl-legacy-provider && webpack --config webpack.prod.js && npm run updateDocAssets",
"coveralls": "cat coverage/client/lcov.info | ./node_modules/.bin/coveralls",
"dev": "vue-play start --standalone",
"dev:build": "vue-play build",
"docs:build": "npm run build && rm -rf ./docs/public && mkdir ./docs/public/ && cd ./docs/public/ && git init && git remote add origin [email protected]:SSENSE/vue-carousel.git && git fetch && git checkout -f gh-pages && cd .. && npm install && ./node_modules/.bin/hexo clean && ./node_modules/.bin/hexo generate",
"lint": "prettier-eslint --write \"src/**/?(*.js|*.vue)\" || exit 1",
"precommit": "lint-staged && npm run test",
"test": "npm run test:client",
"test:client": "jest --config tests/client.jest.json",
"test:client:coverage": "jest --config tests/client.jest.json --coverage",
Expand Down Expand Up @@ -39,7 +37,7 @@
"vue": "^2.5.17"
},
"resolutions": {
"babel-core": "7.0.0-bridge.0"
"babel-core": "7.0.0-bridge.0"
},
"devDependencies": {
"@babel/core": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/Slide.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {
},
inject: ["carousel"],
mounted() {
if (!this.$isServer) {
if (!this.$isServer && this.carousel.mouseDrag) {
this.$el.addEventListener("dragstart", e => e.preventDefault());
}

Expand Down