fix:Github ID type check #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
jagnani73
requested changes
Mar 1, 2022
server/githubsrm/apis/utils.py
Outdated
Comment on lines
48
to
51
| if(res['type']=="User" and response.status_code == 200): | ||
| return response.status_code == 200 | ||
| elif(res['type']!="User" and response.status_code == 200): | ||
| return False |
Member
There was a problem hiding this comment.
Create a nested elif instead of using the same check at two levels
Contributor
Author
There was a problem hiding this comment.
I have made the required changes. The last commit is a wip commit as local env was creating a build issue.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Github ID type check (should be User else return false) in Frontend and Backend using Github API.
Fixes #202
Type of change
Please delete options that are not relevant.
Checklist: