Skip to content

Commit

Permalink
perf: lazy load each module, update eslint config
Browse files Browse the repository at this point in the history
  • Loading branch information
koenpunt committed Dec 13, 2017
1 parent c056a65 commit 74370d1
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 11 deletions.
6 changes: 4 additions & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
{
"env": {
"es6": true
"es6": true,
"node": true
},
"extends": ["eslint:recommended", "plugin:react/recommended"],
"parser": "babel-eslint",
"parserOptions": {
"ecmaVersion": 6
},
"plugins": [
"react"
"react",
"react-native"
],
"rules": {
"comma-dangle": ["error", "always-multiline"],
Expand Down
3 changes: 2 additions & 1 deletion RNAdMobInterstitial.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ const addEventListener = (event, handler) => {
}
_subscriptions.set(handler, listener);
return {
remove: () => removeEventListener(event, handler)
remove: () => removeEventListener(event, handler),
};
} else {
// eslint-disable-next-line no-console
console.warn(`Trying to subscribe to unknown event: "${event}"`);
return {
remove: () => {},
Expand Down
3 changes: 2 additions & 1 deletion RNAdMobRewarded.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ const addEventListener = (event, handler) => {
}
_subscriptions.set(handler, listener);
return {
remove: () => removeEventListener(event, handler)
remove: () => removeEventListener(event, handler),
};
} else {
// eslint-disable-next-line no-console
console.warn(`Trying to subscribe to unknown event: "${event}"`);
return {
remove: () => {},
Expand Down
21 changes: 15 additions & 6 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
import AdMobBanner from './RNAdMobBanner';
import AdMobInterstitial from './RNAdMobInterstitial';
import PublisherBanner from './RNPublisherBanner';
import AdMobRewarded from './RNAdMobRewarded';

export { AdMobBanner, AdMobInterstitial, PublisherBanner, AdMobRewarded };
/* eslint-disable global-require */
module.exports = {
get AdMobBanner() {
return require('./RNAdMobBanner').default;
},
get AdMobInterstitial() {
return require('./RNAdMobInterstitial').default;
},
get PublisherBanner() {
return require('./RNPublisherBanner').default;
},
get AdMobRewarded() {
return require('./RNAdMobRewarded').default;
},
};
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"devDependencies": {
"babel-eslint": "^7.2.3",
"eslint": "^4.3.0",
"eslint-plugin-react": "^7.1.0"
"eslint-plugin-react": "^7.1.0",
"eslint-plugin-react-native": "^3.2.0"
}
}

0 comments on commit 74370d1

Please sign in to comment.