Feature 13294 doctor declarations xml esante adapter#13332
Merged
raulbob merged 7 commits intodevelopmentfrom Apr 16, 2025
Merged
Feature 13294 doctor declarations xml esante adapter#13332raulbob merged 7 commits intodevelopmentfrom
raulbob merged 7 commits intodevelopmentfrom
Conversation
KarnaiahPesula
approved these changes
Apr 15, 2025
…essageProcessingFlow Refactored the lab message package and related classes to extract common functionality allowing doctor declaration to use the same implementation. In the UI part the physician report has been replaced by doctor declaration which is a duplicate of lab message interface. ## API and Backend changes Extracted common functionality from `AbstractLabMessageProcessingFlow` to : - `AbstractMessageProcessingFlowBase` Modified classes to allow sharing of funtinality: - `AbstractProcessingFlow` - `AbstractLabMessageProcessingFlow` - `AutomaticLabMessageProcessor` Moved the lab message specific objects to a common processing package: - `EventValidationResult` - `PersonAndPickOrCreateEntryResult` - `PickOrCreateEventResult` - `PickOrCreateSampleResult` Modified unit tests : - `AbstractLabMessageProcessingFlowTest` ## UI changes Adapted existing classes following refactoring and to include doctor declaration: - `LabMessageProcessingFlow` - `AbstractPhysiciansReportProcessingFlow` - `PhysiciansReportProcessingFlow` - `ExternalMessageController` - `ExternalMessageGrid` Added classes specific to doctor declaration: - `DoctorDeclarationMessageProcessingFlow` - `DoctorDeclarationSlider` - `DoctorDeclarationUiHelper`
DoctorDeclarationMessageProcessingFlow was using wrong package.
…ocessing ## API Changes - `ExternalMessageDto` - `ExternalMessage` - `ExternalMessageFacadeEjb` ## Backend changes - `sormas_schema.sql` ## UI changes - `CaseCreateForm`
## Changes - Fixed merge issue in `AutomaticLabMessageProcessor` ## Updated test cases - `ExternalMessageFacadeEjbMappingTest` - `ExternalMessageFacadeEjbUnitTest`
…factoring of message processing - Added notifier and additional fields to external message - `ExternalMessageDto` - `ExternalMessage` - `ExternalMessageProcessingFacade` - `ExternalMessageFacadeEjbMappingTest` - `ExternalMessageController` - `sormas_schema.sql` - Refactored lab message related classes : - `DoctorDeclarationMessageProcessingFlow` - `AbstractPhysiciansReportProcessingFlow` - `AbstractProcessingFlow` - `AbstractLabMessageProcessingFlow` - Update implemenation and cleaned up the code - `AbstractMessageProcessingFlowBase` - Corrected empty list handling : - `EntrySelectionComponentForExternalMessage`
98cf033 to
6f22e22
Compare
Contributor
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #