Feature 13296 create systemconfiguration table admin UI#13313
Merged
obinna-h-n merged 6 commits intodevelopmentfrom Mar 24, 2025
Merged
Feature 13296 create systemconfiguration table admin UI#13313obinna-h-n merged 6 commits intodevelopmentfrom
obinna-h-n merged 6 commits intodevelopmentfrom
Conversation
system configuration values. Added required captions for interface : - `Captions` - `captions.properties` Added messages and prompts used in SystemConfigurationView: - `Strings` - `strings.properties` Added validation texts for SystemConfigurationValue values: - `Validations` - `validations.properties` --- Added entity for configuration category and backing objects: - `SystemConfigurationCategory` - `SystemConfigurationCategoryCriteria` - `SystemConfigurationCategoryDto` - `SystemConfigurationCategoryHelper` - `SystemConfigurationCategoryIndexDto` - `SystemConfigurationCategoryReferenceDto` - `SystemConfigurationCategoryService` - `sormas-backend/.../persistence.xml` - `sormas-backend/.../test/.../persistence.xml` - `sormas-ui/.../test/.../persistence.xml` Added implementation and facade for configuration categories: - `SystemConfigurationCategoryFacade` - `SystemConfigurationCategoryEjb` Added entity for configuration value and backing objects: - `SystemConfigurationValueCriteria` - `SystemConfigurationValueDto` - `SystemConfigurationValueHelper` - `SystemConfigurationValueIndexDto` - `SystemConfigurationValueReferenceDto` - `SystemConfigurationValueJoins` - `SystemConfigurationValueService` - `sormas-backend/.../persistence.xml` - `sormas-backend/.../test/.../persistence.xml` - `sormas-ui/.../test/.../persistence.xml` Added implementation and facade for configuration values : - `SystemConfigurationValueFacade` - `SystemConfigurationValueEjb` --- Added `SYSTEM_CONFIGURATION` right and updated `ADMIN` default role : - `UserRight` - `DefaultUserRole` - `glassfish-ejb-jar.xml` - `sormas-rest/.../glassfish-web.xml` - `sormas-rest/.../web.xml` - `sormas-ui/.../glassfish-web.xml` - `sormas-ui/.../web.xml` --- Added tables and triggers for system configuration: - `sormas_schema.sql` Added system configuration tables to the export mechanism. - `DatabaseTable` - `DatabaseExportService` --- Exposed added facades : - `FacadeProvider` Updated controllers in : - `ControllerProvider` Added system configuration view and components: - `AbstractConfigurationView` - `SystemConfigurationController` - `SystemConfigurationValueEditForm` - `SystemConfigurationValuesGrid` - `SystemConfigurationView` --- Updated the main test classes to include the new artefacts: - `AbstractBeanTest` - `ArchitectureTest` Added tests: - `SystemConfigurationCategoryFacadeEJbTest` - just simple read tests - `SystemConfigurationValueFacadeEJbTest` : - Read write tests. - Fail and success tests for IP pattern validation. - Fail and success tests for Unix directory path pattern validation. - Fail and success tests for digits-only pattern validation. - Fail and success tests for pipe-separated list of words pattern validation.
Added additional fields to `SystemConfigurationValue` to support custom value provisioning and transformation. Added required captions for interface : - `Captions` - `captions.properties` Added validation messages : - `Validations` - `validations.properties` --- Added backing objects for supporting dynamic input data provision: - `SystemConfigurationValueDataProvider` - `SystemConfigurationValueDiseasesProvider` - `SystemConfigurationValueBooleanProvider` Modified System Configuration glue logic : - `SystemConfigurationValueEjb` - `SystemConfigurationValueEjb` Adapted entities : - `SystemConfigurationValueDto` - `SystemConfigurationValueIndexDto` - `SystemConfigurationCategory` - `SystemConfigurationValue` --- Added `SYSTEM_CONFIGURATION` right and updated `ADMIN` default role : - `UserRight` - `DefaultUserRole` - `glassfish-ejb-jar.xml` - `sormas-rest/.../glassfish-web.xml` - `sormas-rest/.../web.xml` - `sormas-ui/.../glassfish-web.xml` - `sormas-ui/.../web.xml` --- Updated tables for system configuration: - `sormas_schema.sql` --- Added dynamic input component and supporting objects: - `SystemConfigurationI18nHelper` - `SystemConfigurationValueDtoWrapper` - `SystemConfigurationValueDynamicInput` Modified system configuration view and components: - `SystemConfigurationValueEditForm` - `SystemConfigurationValuesGrid` - `SystemConfigurationView` Added styles for dynamic input checkbox grid: - `global.scss` --- Updated systemconfiguration tests: - `SystemConfigurationCategoryFacadeEJbTest` - `SystemConfigurationValueFacadeEJbTest` Added tests: - `SystemConfigurationValueBooleanProviderTest` - `SystemConfigurationValueDiseasesProviderTest`
Added support for creating and modifying system configuration values programatically from other modules. Added optional flag to system configuration values to allow empty values. ## Changes ### Business Logic Modified system configuration category and value facades: - `SystemConfigurationCategoryFacade.java` - `SystemConfigurationValueFacade.java` Modified System configuration logic : - `SystemConfigurationCategoryEjb` - `SystemConfigurationValueEjb` - `SystemConfigurationCategoryService` Modified entites and DTOs : - `SystemConfigurationCategoryDto.java` - `SystemConfigurationValueDto.java` --- ### Database Added new columns for optional flags in system configuration values: - `sormas_schema.sql` --- ### Tests Updated systemconfiguration tests: - `SystemConfigurationCategoryFacadeEJbTest` - `SystemConfigurationValueFacadeEJbTest` Moved tests to sormas-api: - `SystemConfigurationValueBooleanProviderTest` - `SystemConfigurationValueDiseasesProviderTest`
### Tests Deleted tests from sormas-backend: - `SystemConfigurationValueBooleanProviderTest` - `SystemConfigurationValueDiseasesProviderTest`
In sormas_schema.sql, the system configuration sqls were with wrong version.
Contributor
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13313 |
obinna-h-n
deleted the
feature-13296_create_systemconfiguration_table_admin_ui
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13296 - Implementation for Sysstem Configuration interface