Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the org_config Object #3490

Merged
merged 17 commits into from
Jan 17, 2025

Conversation

RupertBarrow
Copy link
Contributor

@RupertBarrow RupertBarrow commented Jan 16, 2023

To fix #2424, I have created a document called org_config.md under docs, and added this paragraph to the reference.md chapter.

At the same time, I fixed the name of the env-var-reference chapter which was incorrectly referenced in reference.md and, thus, did not appear in the generated documentation.

I scoured the source code for these attributes, leaving out the attributes with names starting with an underscore, as well as salesforce_client and tooling which sound like reserved for internal use.
I guessed the use of most of the attributes from their name. When in doubt, I left attributes with unknown use in a separate list.

@RupertBarrow RupertBarrow marked this pull request as ready for review January 16, 2023 19:09
@RupertBarrow RupertBarrow requested a review from a team as a code owner January 16, 2023 19:09
@prescod prescod added the ignore-for-release Don't include in release notes label Jan 17, 2023
@yippie
Copy link
Contributor

yippie commented May 20, 2024

More documentation is always good!

@RupertBarrow RupertBarrow requested a review from yippie May 23, 2024 13:35
@Julian88Tex
Copy link
Contributor

@RupertBarrow thanks for this!

@RupertBarrow
Copy link
Contributor Author

Hi @yippie , is anyone going to merge this PR one day ?
Are you expecting more inputs from me (the author of the PR) ?

@RupertBarrow
Copy link
Contributor Author

I just update this documentation after reading about has_minimum_package_version() in https://trailhead.salesforce.com/fr/trailblazer-community/feed/0D54V00007erukZSAQ

jstvz
jstvz previously requested changes Nov 16, 2024
Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @RupertBarrow. Apologies for the delay in reviewing it.

Just a needs a few tweaks before we merge it.

docs/reference.md Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
docs/org_config-reference.md Outdated Show resolved Hide resolved
@jstvz jstvz enabled auto-merge (squash) November 16, 2024 00:58
Co-authored-by: James Estevez <[email protected]>
auto-merge was automatically disabled December 13, 2024 16:04

Head branch was pushed to by a user without write access

@jstvz jstvz dismissed their stale review January 17, 2025 21:10

Committed to PR

@jstvz jstvz requested review from vsbharath and removed request for yippie January 17, 2025 21:11
@jstvz jstvz enabled auto-merge (squash) January 17, 2025 21:16
@jstvz jstvz merged commit 53f807b into SFDO-Tooling:main Jan 17, 2025
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed ignore-for-release Don't include in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should document org_config options for when clauses
6 participants