data sce correction fcls #732
Conversation
There was a problem hiding this comment.
Thanks @wjdanswjddl
Changes look good to me. I've left one optional comment (to remove the lines in reco2_data.fcl. And one followup question about some remaining lines in workflow_reco2.fcl.
There was a problem hiding this comment.
Hi Moon, thank you for making this pull request! I have reviewed the parts regarding calorimetry and chi2 PID. As far as I understand, correct labels are used so far. So, an approval from my side. One note for all is that TPC gain calibration constants called by pandoraSCECaloData are measured without SCE correction. So, there could be a percent level bias. This should be revisited for the next iteration once corrections such as charge uniformity correction are delivered.
|
Looks good to me! Hopefully we'll see the correction in data isn't doing anything crazy after this is enabled (not sure if that's been studied yet?) |
sbndcode/JobConfigurations/standard/caf/cafmakerjob_sbnd_data_sce.fcl
Outdated
Show resolved
Hide resolved
tables for crtspacepointmatchingSCE and crttrackmatchingSCE Co-authored-by: Henry Lay <[email protected]>
override crt labels for data Co-authored-by: Henry Lay <[email protected]>
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
approved |
Description
updates on fcls to enable SCE correction on data
workflow_reco2.fclupdated with pandoraSCE(Calo,Pid)Datareco2_data.fclupdated to run SCE modulescafmakerjob_sbnd_data_sce.fclmade with SCE labels, to serve as the cafmakerjob base fcl with SCE correctioncafmakerjob_sbnd_data_(bnblight,bnbzerobias,offbeamlight)_sce.fclare copies of the non-sce fcls, inheritingcafmakerjob_sbnd_data_sce.fclinstead ofcafmakerjob_sbnd_data_base.fclChecklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?