-
Notifications
You must be signed in to change notification settings - Fork 34
Updates to Enable Spring Production #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This includes LVDS/adder bits, trigger logic and trigger tick (new!) also for minimum bias events when such information is present.
This includes would-be trigger information in minimum bias events.
…s of two-faced ICARUS wires config.
… jsonnets for various WC SP configs. Move parameters out of json config into fcl config.
…e due to the different filter width).
…s well the modules converting from Wire to/from ChannelROI. Removing from icaruscode
…PC products. Move hit finding to stage1. Remove (for now) analyzers that were relying on stage0 hit making.
… WC signal processing.
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00 SBNSoftware/sbnalg@v10_06_00 SBNSoftware/sbnobj@v10_01_00 |
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00 SBNSoftware/sbnalg@v10_06_00 SBNSoftware/sbnobj@v10_01_00 SBNSoftware/icarus_data@v09_93_05 |
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00 SBNSoftware/sbnalg@v10_06_00 SBNSoftware/sbnobj@v10_01_00 |
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
…uscode into release/Mar25Production
This PR makes updates to icaruscode necessary to enable the Spring production. It depends on:
SBNSoftware/sbncode#526
WireCell/wire-cell-toolkit#400 (will need a new cut of WireCell+LArSoft with this in)
SBNSoftware/sbncode#535
SBNSoftware/sbnobj#129
It will need a new cut of icarus_data with the following files added in (please reach out to me to get them):
WirecellData/icarus_wire_twofaced.json.bz2
WirecellData/NNs/plane0.ts
WirecellData/NNs/plane1.ts
tpc_channelstatus_data.db (new copy with tag 'v3r4')
New PMT calibration database files are also needed (see #807). A new TPC calibration database file is also needed (see #792):
tpc_yz_correction_allplanes_data.db
It incorporates the following PRs (and can be merged either instead of or after those):
#774
#777
#817
#784
#809
#814
#816
#807
#819
#740
It also incorporates #792, onto the develop branch.
This PR enables 2D signal processing for ICARUS, both flavors with and without DNN ROIs. It incorporates the "YZ" intransparency simulation, and organizes all of the recent development in ICARUS detector simulation into the mainline detsim config (see https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=40360). It extends @cerati's work in G4 configurations and reorganizes detsim, stage0, and stage1 configurations into a new, more orderly format. It incorporates ChannelROI-based region of interest objects (replacing recob::Wire's) to reduce file size. It moves hit finding from stage0 to stage1 to reduce file size and optimize memory usage. Finally, it also includes updates to the calibration NTupler to enable integration with the CRT (to T0 tag tracks).