fix: button group border asymmetry and size/pill composition breakage#882
Open
siddhantsinghbussiness-afk wants to merge 1 commit into
Conversation
siddhantsinghbussiness-afk
requested a review
from SAPTARSHI-coder
as a code owner
SAPTARSHI-coder
added
accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where the
.ease-btn-groupwrapper class hardcodedborder-radius: var(--ease-radius-md)on its boundary buttons, breaking styling consistency when combining different sizes or shapes (such as small, large, or pill buttons). It also addresses the asymmetry and uneven border thicknesses of adjacent outline buttons.Changes
.ease-btn-groupincomponents/buttons.cssto respect the.ease-btn-pill,.ease-btn-sm,.ease-btn-lg, and.ease-btn-xlmodifier classes on the:first-childand:last-childbuttons.border-right-width: 1pxoverride with a symmetric negative margin overlay (margin-right: -2pxcorresponding to the button's2pxborder width).z-index: 1triggers on hover, focus-visible, and active interactions to ensure borders render correctly when interactive.easemotion.min.css.examples/demo.htmlto showcase and verify these sizing and pill layouts.Fixes #881