fix: add zoom-in duplicate class bug demo (fixes #872)#875
Open
Krish0703-irl wants to merge 1 commit into
Open
fix: add zoom-in duplicate class bug demo (fixes #872)#875Krish0703-irl wants to merge 1 commit into
Krish0703-irl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This submission demonstrates the
.ease-zoom-induplicate class bug incore/animations.cssby showing both conflicting animations side-by-side, making it easy for the maintainer
to visually confirm the correct behavior before fixing it in core.
Related issue: #872
Type of Change
Submission Checklist
submissions/examples/ZoomIn-Duplicate-Fix/demo.html— self-contained, opens in browser with no serverstyle.css— raw CSS for the proposed featureREADME.md— what it does, how to use it, why it fits EaseMotion CSScore/components/Feature Description
What does this add?
A side-by-side demo exposing the
.ease-zoom-induplicate class bug where twodifferent
@keyframesblocks produce conflicting behavior and one is dead code.How does a developer use it?
Why does it fit EaseMotion CSS?
EaseMotion CSS is animation-first and consistency is core to its philosophy.
Having two definitions of
.ease-zoom-inreferencing different keyframes breaksthat consistency — one animates from
scale(0)with no opacity change, the otherfrom
opacity:0, scale(0.85)using design tokens. The second definition silentlywins via CSS cascade, making the first dead code. This demo makes the case for
cleaning up the duplicate so the framework behaves predictably.
Demo
demo.htmlworks by opening directly in a browser)Browser Testing
Notes for Maintainer
This PR is a companion to issue #872. The core fix requires:
.ease-zoom-inblock (~line 452) and orphaned@keyframes ease-zoom-inease-kf-zoom-inwith design tokens@keyframes ease-kf-slide-image-exit(lines 333, 372, 390),@keyframes ease-kf-shimmer-sweep(lines 343, 382) and.ease-shimmer-sweepclass (lines 499, 516)easemotion.min.cssvianpm run buildFeel free to adjust timing or naming during integration.