fix: replace hardcoded max-width in .ease-container with CSS variable#870
Open
Pcmhacker-piro wants to merge 1 commit into
Open
Conversation
- Added --ease-container-max: 1200px to core/variables.css
- Updated .ease-container in core/utilities.css to use var(--ease-container-max)
Users can now override container width via
:root { --ease-container-max: 960px; }
without needing !important.
Closes SAPTARSHI-coder#847
Author
|
heyy @SAPTARSHI-coder i fixed the your assigned issue so please check this |
Author
|
heyy @SAPTARSHI-coder |
1 similar comment
Author
|
heyy @SAPTARSHI-coder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--ease-container-max: 1200pxtocore/variables.css.ease-containerincore/utilities.cssto usevar(--ease-container-max)Users can now override container width via
:root { --ease-container-max: 960px; }without needing
!important.Closes #847
Pull Request Description
.ease-containerhad a hardcodedmax-width: 1200pxthat could not be themed via CSS variables. This PR introduces--ease-container-maxas a design token, making the container width fully customizable.Type of Change
CSS variable theming fix for
.ease-container.Submission Checklist
submissions/examples/your-feature-name/demo.html— self-contained, opens in browser with no serverstyle.css— raw CSS for the proposed featureREADME.md— what it does, how to use it, why it fits EaseMotion CSScore/components/Feature Description
What does this add?
CSS variable
--ease-container-max(default1200px) to make.ease-containerwidth themable.How does a developer use it?