Skip to content

fix: declare --ease-color-secondary in variables.css#862

Open
Pcmhacker-piro wants to merge 1 commit into
SAPTARSHI-coder:mainfrom
Pcmhacker-piro:fix/add-secondary-color-token-841
Open

fix: declare --ease-color-secondary in variables.css#862
Pcmhacker-piro wants to merge 1 commit into
SAPTARSHI-coder:mainfrom
Pcmhacker-piro:fix/add-secondary-color-token-841

Conversation

@Pcmhacker-piro
Copy link
Copy Markdown

@Pcmhacker-piro Pcmhacker-piro commented Jun 1, 2026

Closes #841

Pull Request Description

--ease-color-secondary was referenced in animations.css with a
hardcoded #8b5cf6 fallback but never declared in variables.css,
preventing users from theming the secondary color.

Type of Change

  • ✨ New animation / hover effect
  • 🧩 New component
  • 📝 Documentation improvement
  • 🐛 Bug fix in an existing submission
  • Other (describe below)

CSS variable declaration fix.

Submission Checklist

N/A — this PR fixes core framework files, not a user submission.

Notes for Maintainer

Matches the existing --ease-color-primary variable pattern.
Values chosen to match the #8b5cf6 (violet) already used as fallback.

fix: declare --ease-color-secondary in variables.css
4ef921a 
- Added --ease-color-secondary, --ease-color-secondary-light,
  --ease-color-secondary-dark to core/variables.css
- Added --ease-glow-secondary glow token
- Removed hardcoded #8b5cf6 fallback from animations.css line 529
  (now references var(--ease-color-secondary) directly)

Closes SAPTARSHI-coder#841
@Pcmhacker-piro
Copy link
Copy Markdown
Author

Pcmhacker-piro commented Jun 1, 2026 •
edited
Loading

hey @SAPTARSHI-coder i fixed this assign issue so please check it

@SAPTARSHI-coder SAPTARSHI-coder added accepted Contribution approved for integration into EaseMotion CSS animation Animation effects, hover interactions, motion ideas, transitions component New UI components (buttons, cards, modals, tooltips, badges) enhancement New feature or request good first issue Good for newcomers GSSoC-26 Official GSSoC 2026 issue gssoc:approved Approved for GSSoC contributions integrated Successfully merged and included in the framework level:intermediate Requires moderate project understanding type:feature New functionality or enhancement labels Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SAPTARSHI-coder SAPTARSHI-coder Awaiting requested review from SAPTARSHI-coder SAPTARSHI-coder is a code owner

Assignees

@Pcmhacker-piro Pcmhacker-piro

@SAPTARSHI-coder SAPTARSHI-coder

Labels

accepted Contribution approved for integration into EaseMotion CSS animation Animation effects, hover interactions, motion ideas, transitions component New UI components (buttons, cards, modals, tooltips, badges) enhancement New feature or request good first issue Good for newcomers gssoc:approved Approved for GSSoC contributions GSSoC-26 Official GSSoC 2026 issue integrated Successfully merged and included in the framework level:intermediate Requires moderate project understanding type:feature New functionality or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

### --ease-color-secondary Referenced in animations.css But Never Declared in variables.css

2 participants

@Pcmhacker-piro @SAPTARSHI-coder