Skip to content

Conversation

@D047539
Copy link
Contributor

@D047539 D047539 commented Jul 15, 2025

Following the AFF review for AIFA, we have decided to add type fields for the variable and the field value in the AIFP object.

@Markus1812
Copy link
Member

Markus1812 commented Jul 28, 2025

Hi Nicole, removing and adding fields are incompatible changes and normally require bumping the format version. If you already contributed to abapGit, implemented the XCO APIs, or delivered the AFF classes in an on-premises release (2025), you have to take care about the compatibility of your change.
The most important question would be, if you have released your transports containing the AFF classes before the 2508/2025 dev close?

@D047539
Copy link
Contributor Author

D047539 commented Aug 12, 2025

Hi Nicole, removing and adding fields are incompatible changes and normally require bumping the format version. If you already contributed to abapGit, implemented the XCO APIs, or delivered the AFF classes in an on-premises release (2025), you have to take care about the compatibility of your change. The most important question would be, if you have released your transports containing the AFF classes before the 2508/2025 dev close?

Hi Markus, the ABAP artifacts, including the AFF classes and the AFF interface, were released before on-premises release (2025) launch. However, the AIFP object itself has not yet been fully released (final sign off is missing) and is consequently unavailable in the customer's ADT.

@Markus1812
Copy link
Member

@schneidermic0 If AFF classes and the AFF interface were already shipped with OP2025 SP0, the format version has to be raised for incompatible changes, correct? When the zabapGit handler will be implemented in the future (which is release independent), (de-)serialization between OP2025 SP0 and SP1 systems will fail.

@D047539
Copy link
Contributor Author

D047539 commented Aug 14, 2025

@schneidermic0 If AFF classes and the AFF interface were already shipped with OP2025 SP0, the format version has to be raised for incompatible changes, correct? When the zabapGit handler will be implemented in the future (which is release independent), (de-)serialization between OP2025 SP0 and SP1 systems will fail.

Hi,
just a quick note from us.
The AIFP object has not been included completely in the OP 2025 release yet. Although there are some ABAP artifacts, they aren't utilized in OP 2025. The full and functional delivery of this object is scheduled for a later date. Consequently, I believe there is no reason for OP customers to import this object into the system using JSON at this time.

@schneidermic0
Copy link
Contributor

Thanks, @Markus1812, for pointing this out. I think, @D047539 and team has to decide whether AIFP shall be supported in the mentioned releases.

If it shall be supported, we

  1. either introduce a format version to distinguish both
  2. or provide all updates we suggest here also for all supported releases.

If it don't need to be supported, I suggest to remove the registration in the corresponding release from the repository object type (SVAL) of AIFP so that the AFF handler cannot be called (e.g. by our generic abapGit implementation)

@D047539
Copy link
Contributor Author

D047539 commented Aug 20, 2025

Thanks, @Markus1812, for pointing this out. I think, @D047539 and team has to decide whether AIFP shall be supported in the mentioned releases.

If it shall be supported, we

  1. either introduce a format version to distinguish both
  2. or provide all updates we suggest here also for all supported releases.

If it don't need to be supported, I suggest to remove the registration in the corresponding release from the repository object type (SVAL) of AIFP so that the AFF handler cannot be called (e.g. by our generic abapGit implementation)

The repository object AIFP will not be supported with the current release and a SAP note to prevent incorrect use of the AIFP object will be provided.

Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michael.

I have some very small comments regarding the changes in the AFF. If you could please check below.

Copy link

@GuilhermeSaraiva96 GuilhermeSaraiva96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a question

Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update.

@Markus1812 Markus1812 merged commit 2dda490 into SAP:main Sep 10, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants