-
Notifications
You must be signed in to change notification settings - Fork 72
[AIFP] Inserting Field Type and Variable Type in AIFP #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi Nicole, removing and adding fields are incompatible changes and normally require bumping the format version. If you already contributed to abapGit, implemented the XCO APIs, or delivered the AFF classes in an on-premises release (2025), you have to take care about the compatibility of your change. |
Hi Markus, the ABAP artifacts, including the AFF classes and the AFF interface, were released before on-premises release (2025) launch. However, the AIFP object itself has not yet been fully released (final sign off is missing) and is consequently unavailable in the customer's ADT. |
|
@schneidermic0 If AFF classes and the AFF interface were already shipped with OP2025 SP0, the format version has to be raised for incompatible changes, correct? When the zabapGit handler will be implemented in the future (which is release independent), (de-)serialization between OP2025 SP0 and SP1 systems will fail. |
Hi, |
|
Thanks, @Markus1812, for pointing this out. I think, @D047539 and team has to decide whether AIFP shall be supported in the mentioned releases. If it shall be supported, we
If it don't need to be supported, I suggest to remove the registration in the corresponding release from the repository object type (SVAL) of AIFP so that the AFF handler cannot be called (e.g. by our generic abapGit implementation) |
The repository object AIFP will not be supported with the current release and a SAP note to prevent incorrect use of the AIFP object will be provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Michael.
I have some very small comments regarding the changes in the AFF. If you could please check below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update.
Following the AFF review for AIFA, we have decided to add type fields for the variable and the field value in the AIFP object.